Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place of Worship preset: "Religion" field disappears after filling-in some data #5611

Closed
my-na-me opened this issue Dec 16, 2018 · 5 comments
Labels
usability An issue with ease-of-use or design

Comments

@my-na-me
Copy link

see movie:
pow

@bhousel bhousel added the bug A bug - let's fix this! label Dec 16, 2018
@bhousel
Copy link
Member

bhousel commented Dec 16, 2018

cc @quincylvania

@quincylvania
Copy link
Collaborator

Hi @my-na-me! So it looks like it’s working as intended, but I can see how it is confusing.

When you set the religion, the preset subtlety updates from Place of Worship to Church, which has the same fields except for Religion. We might improve this by calling the latter preset Christian Church and/or keeping the Religion field around so people can easily view or correct the religion tag.

@bhousel
Copy link
Member

bhousel commented Dec 16, 2018

When you set the religion, the preset subtlety updates from Place of Worship to Church, which has the same fields except for Religion. We might improve this by calling the latter preset Christian Church and/or keeping the Religion field around so people can easily view or correct the religion tag.

Oh yeah good catch @quincylvania .. I like the proposed solution to make these presets less confusing.

@RudyTheDev
Copy link
Contributor

I think the preset selector button should visibly highlight itself briefly whenever it gets changed other than directly.

@quincylvania quincylvania added usability An issue with ease-of-use or design and removed bug A bug - let's fix this! labels Dec 18, 2018
@bhousel bhousel closed this as completed in f1b5c4e Jan 7, 2019
bhousel added a commit that referenced this issue Jan 7, 2019
@bhousel
Copy link
Member

bhousel commented Jan 7, 2019

I made these changes per above comments:

  • Make sure the "religion" field will not disappear (I added it for all the religion-specific amenities)
  • Make sure that the religion appears in the preset label (e.g. renamed "Church" -> "Christian Church")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

4 participants