Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silent overflow of max character length for values #4061

Closed
dieterdreist opened this issue May 22, 2017 · 3 comments
Closed

silent overflow of max character length for values #4061

dieterdreist opened this issue May 22, 2017 · 3 comments
Labels
bug A bug - let's fix this! considering Not Actionable - still considering if this is something we want

Comments

@dieterdreist
Copy link

I just coincidentally discovered that iD doesn't warn when you try to add long tags.

  1. Added new tag (via copy+paste) image=http://www.sovraintendenzaroma.it/var/sovrintendenza/storage/images/i_luoghi/roma_antica/monumenti/cisterna_della_via_colombo/cisterna_della_via_colombo/cisterna_della_via_colombo_veduta_aerea/57816-1-ita-IT/cisterna_della_via_colombo_veduta_aerea_gallery.jpg and uploaded it. No error but the url is incomplete.

I became aware of the issue because I then tried to do it with the level0 editor and it replied:

OAuth error 400 at stage "upload": WayTag 66599244,image: v: is too long (maximum is 255 characters) ("http://www.sovraintendenzaroma.it/var/sovrintendenza/storage/images/i_luoghi/roma_antica/monumenti/cisterna_della_via_colombo/cisterna_della_via_colombo/cisterna_della_via_colombo_veduta_aerea/57816-1-ita-IT/cisterna_della_via_colombo_veduta_aerea_gallery.jpg").

I suggest to issue a similar warning in iD.

@bhousel bhousel added the considering Not Actionable - still considering if this is something we want label May 22, 2017
@mmd-osm
Copy link
Contributor

mmd-osm commented Apr 10, 2018

No error but the url is incomplete.

Truncation already occurs when you paste your URL into iD's value field. The maximum length of 255 is checked by your browser. Level0 doesn't have this kind of validation, the message you were seeing is the error message returned by the OSM API.

@quincylvania
Copy link
Collaborator

It might be useful to have a tweet-like character count for certain fields if the value gets long. But I also wonder if the problem is common enough to spend time on.

@tyrasd
Copy link
Member

tyrasd commented May 27, 2024

As of v2.24 there is a max-length indicator and warning, see screenshot below. I believe this should sufficiently address the issue.

image

@tyrasd tyrasd closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! considering Not Actionable - still considering if this is something we want
Projects
None yet
Development

No branches or pull requests

5 participants