Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag values over 255 characters long are silently truncated in raw tag editor #10241

Open
fabi003 opened this issue May 12, 2024 · 4 comments
Open

Comments

@fabi003
Copy link

fabi003 commented May 12, 2024

URL

https://www.openstreetmap.org/node/11829238608/history

How to reproduce the issue?

Enter a tag value longer then 255 characters, as tag value for some key and then upload the changeset.

They value of the tag will be truncated after upload.

This easily occurs when writing complex opening_hours=* with comments, as common e.g. for German physicians (after I hit the 255 char limit limit the 2nd time, I report it now). You can also look at the the German opening_hours=*-page (machine translated), if you need some more complex rule examples.

Screenshot(s) or anything else?

The user should be notified about this and the actual length of the values over the 255 character limit should be displayed in some kind to help to shorten the comments or remove some whitespaces.

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.29.0

Which browsers are you seeing this problem on?

Firefox

@riQQ
Copy link
Contributor

riQQ commented May 12, 2024

Duplicate of #4061

@tordans tordans closed this as not planned Won't fix, can't repro, duplicate, stale May 12, 2024
@tyrasd
Copy link
Member

tyrasd commented May 27, 2024

@fabi003: Did you not get the warning message that the entered value is longer than 255 characters? It should look something like this:

image

@fabi003
Copy link
Author

fabi003 commented May 27, 2024

If I pasted the opening hours into the input fields in the above picture, I got this warning (I found it out after this issue report). If I paste the opening_hours=* into the generic tag editor, what I do in most times, when adding/editing tags, I don't get any warnings.

@tyrasd tyrasd reopened this May 29, 2024
@tyrasd tyrasd changed the title Tag values over 255 characters long are silently truncated if uploaded Tag values over 255 characters long are silently truncated in raw tag editor May 29, 2024
@tyrasd
Copy link
Member

tyrasd commented May 29, 2024

ok, I didn't think about the raw tag editor. There should be a similar indicator and warning also in those input fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants