Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace png assets with svg #2785

Closed
4 of 5 tasks
bhousel opened this issue Sep 21, 2015 · 5 comments
Closed
4 of 5 tasks

Replace png assets with svg #2785

bhousel opened this issue Sep 21, 2015 · 5 comments

Comments

@bhousel
Copy link
Member

bhousel commented Sep 21, 2015

These things are all available in svg and will look much better on retina. Using svg would also eliminate the extra build step generating the png.

  • line preset icons -> move to sprite.svg
  • relation preset icons -> move to sprite.svg
  • Maki
  • cursors? check browser support first.
  • cleanup /svg folder

capturing convo w/@samanpwbb

@bhousel bhousel added the design label Sep 25, 2015
@bhousel
Copy link
Member Author

bhousel commented Nov 4, 2015

Rolling most of this into #2811, will merge what is done in the next few days, and consider svg cursors another time.

@sisskind
Copy link

@bhousel Having an issue getting the SVG icons to appear, specifically the menu (zoom in, zoom out, etc.) The feature icons are appearing when the dataset is loaded. Have run the npm install command and make clean && make, but just getting blank icons. Is there something I am missing?

@bhousel
Copy link
Member Author

bhousel commented Jan 30, 2016

We did have an error in the makefile that was causing the svg sprite to not get built unless svg-sprite was in your path. Are you testing this with latest code from master?

You can also try rm -rf node_modules and the redo the npm install step. This sometimes can clear things up, e.g. if you got stuck with an unlucky combination of dependency versions.

@tmcw
Copy link
Contributor

tmcw commented Aug 11, 2016

According to this document, SVG cursors aren't supported in WebKit and this testcase confirms that.

@bhousel
Copy link
Member Author

bhousel commented Aug 11, 2016

Thanks for checking! We'll close this..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants