Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iD Editor Upstream Merge #139

Closed
sisskind opened this issue Jan 4, 2016 · 12 comments
Closed

iD Editor Upstream Merge #139

sisskind opened this issue Jan 4, 2016 · 12 comments

Comments

@sisskind
Copy link

sisskind commented Jan 4, 2016

Update iD Editor to v1.8.5.

@sisskind
Copy link
Author

@sisskind
Copy link
Author

May need to revisit css/map.css

@sisskind
Copy link
Author

need to revisit js/id/svg/tag_classes.js

@sisskind
Copy link
Author

Moved to backlog pending ATP.

@sisskind
Copy link
Author

Main issue with initial merge was with new SVG icons.
Remember to run npm install svg-sprite -g when doing merge in future.

@sisskind
Copy link
Author

Updating to 1.9.2

@sisskind
Copy link
Author

sisskind commented Apr 1, 2016

@sisskind
Copy link
Author

sisskind commented Apr 7, 2016

Committed to develop. @mjeffe98 ready for review. If you see the following, can assume that this is complete:

  1. See toggle icon (layers) and go to review icon in radial menu when in review mode
  2. Can see Map-in-map checkbox in sidebar (Map Data)
  1. All other icons appear as they should

@mikejeffe
Copy link

@sisskind I'm ready to sign off on this assuming that the work for #351 is complete.

@mikejeffe
Copy link

@sisskind how do you want me to treat testing of this? I think we should close it and then open new issues as they are discovered. This is too much of a "regression-ey" ticket which has a very vague set of testing criterion. thoughts?

@sisskind
Copy link
Author

I made it into an Epic using ZenHub, so once the others are closed we can close it out. I'll take the lead on tracking and closing when ready.

@mikejeffe
Copy link

thanks. I just didn't know about the ready for test state. thanks for clarifying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants