Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brightness Control Does not Work #351

Closed
sisskind opened this issue Apr 7, 2016 · 10 comments
Closed

Brightness Control Does not Work #351

sisskind opened this issue Apr 7, 2016 · 10 comments

Comments

@sisskind
Copy link

sisskind commented Apr 7, 2016

Following the upstream merge, it appears that the brightness control is not working.

@sisskind
Copy link
Author

sisskind commented Apr 7, 2016

@mjeffe98 Ready for test. Should be able to adjust brightness levels as before.

@sisskind
Copy link
Author

sisskind commented Apr 8, 2016

@mjeffe98 reopening - seems that it was not correctly mitigated.

@mikejeffe
Copy link

@sisskind the brightness controller does appear to be functioning correctly i.e. I have 4 brightness options from 100-25% and all behave properly. Working off of 0.2.23_615_g933e088_dirty

@sisskind
Copy link
Author

sisskind commented Apr 8, 2016

@mjeffe98 on Version: 0.2.23_622_gb0d8f4c_dirty and does not seem to be working. Will see what changed and will fix/commit. Also true for gap between tiles.

@mikejeffe
Copy link

@sisskind please send me a screencap of the gap between tiles. I want to know what to look for since I'm on 624 and the issue is not obvious to me

@sisskind
Copy link
Author

sisskind commented Apr 8, 2016

@mjeffe98 Leaving gap on backlog since this appears to be a known issue that occurred prior to merge.

@sisskind
Copy link
Author

sisskind commented Apr 8, 2016

Brightness issue has been resolved and is ready for test.

@mikejeffe
Copy link

@sisskind not sure exactly why but the gaps that appear for the same imagery basemap services were not visible in 0.2.23_615 are now strikingly noticeable in latest dev. Ignoring this issue, the background brightness controller works.

@mikejeffe
Copy link

@sisskind looking at Version: 0.2.23_643_g22548b4_dirty - Built By: vagrant and the brightness controller isn't responding. Can you confirm on your version?

@mikejeffe
Copy link

disregard @sisskind I can see this working on 0.2.23_648_g963c3b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants