Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature to read and apply Qt style sheet from file #1528

Closed
wants to merge 0 commits into from

Conversation

MarkoSchuetz
Copy link
Contributor

Summary of changes

If a file 'plover.qss' is present in the config directory then it gets read at the initialization of the Application.

Closes #1514

Pull Request Checklist

  • Changes have tests
  • [x ] News fragment added in news.d. See documentation for details

plover/gui_qt/main.py Outdated Show resolved Hide resolved
plover/gui_qt/main.py Outdated Show resolved Hide resolved
plover/gui_qt/main.py Outdated Show resolved Hide resolved
news.d/feature/1514.ui.md Outdated Show resolved Hide resolved
@MarkoSchuetz
Copy link
Contributor Author

I made the corresponding changes. Please review again.

Copy link
Contributor Author

@MarkoSchuetz MarkoSchuetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with the changes made this is ready to merge. Are you waiting for anything more from me?

@benoit-pierre
Copy link
Member

OK, I messed up trying to update the PR... Next time please do your work in a dedicated branch (not master). New PR here: #1535.

I've added #1534 to fix the error handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load and use Qt application style sheets from Plover.qss file
3 participants