Improve serial port handling #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
benoit-pierre
force-pushed
the
improve_serial_port_handling
branch
from
515e4f3 to
447a506
Compare
Too much trouble to maintain.
To `suppress`, in preparation for output plugins / locking keys support.
To avoid calling the capture' `suppress` method when it has not yet been started.
In preparations for changing `KeyboardCapture` to inherit from a base capture class: use composition instead of inheriting from `threading.Thread`.
In preparations for changing `KeyboardCapture` to inherit from a base capture class: use composition instead of inheriting from `threading.Thread`.
In preparations for changing `KeyboardCapture` to inherit from a base capture class: use composition instead of inheriting from `threading.Thread`.
To become the basis for 2 new plugin types.
Add platform specific sub-packages.
Add platform specific implementations of `patch_ports_info`: - on Linux: patch device paths to use device-by-id links - on Windows: fix erroneous manufacturer information
Use a custom item delegate for the combo box to show detailed information for each device (when available).
benoit-pierre
force-pushed
the
improve_serial_port_handling
branch
from
447a506 to
0e12688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
For the configuration widget of serial machines, use a custom item delegate for the serial combo box to show detailed information for each device (when available).
Additionally, use a platform specific helper for improving the serial ports information returned by
pyserial:pyserialis used as-is.I looked at improving the situation on Windows, and trying to use PyUSB does not work (I think because of a concurrent access issue with the serial driver), and the only other thing that I can think of is to embed a list of USB IDs, such as the one provided by the USB ID Repository.
Note this PR includes #1509.
Closes #789.
Pull Request Checklist
- [ ] Changes have tests