-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dictionary implementation test framework #1302
Merged
benoit-pierre
merged 11 commits into
openstenoproject:master
from
benoit-pierre:improve_dictionary_implementation_test_framework
May 14, 2021
Merged
Improve dictionary implementation test framework #1302
benoit-pierre
merged 11 commits into
openstenoproject:master
from
benoit-pierre:improve_dictionary_implementation_test_framework
May 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
benoit-pierre
force-pushed
the
improve_dictionary_implementation_test_framework
branch
from
April 29, 2021 02:58
ee36da0
to
d3e70f8
Compare
TheaMorin
reviewed
May 14, 2021
Class decorator for torturing a dictionary implementation.
tests: use `dictionary_test`
If the class implementation is marked as read-only, then loading from a writable file should still result in a read-only dictionary.
benoit-pierre
force-pushed
the
improve_dictionary_implementation_test_framework
branch
from
May 14, 2021 19:52
d3e70f8
to
24bbd90
Compare
benoit-pierre
deleted the
improve_dictionary_implementation_test_framework
branch
May 14, 2021 19:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add
plover_build_utils.testing.dictionary_test
helper, usage:Fix 2 issues with
StenoDictionary
implementation:clear
on a read-only dictionary.Pull Request Checklist