formatting & translations: add support for prefix strokes #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user202729
reviewed
Oct 24, 2020
plover/formatting.py
Outdated
| @@ -576,6 +578,8 @@ def __init__(self, | |||
|
|
|||
| upper_carry -- True if we are uppercasing the current word. | |||
|
|
|||
| word_is_finished -- True if word is finished. | |||
|
|
|||
| othography -- True if orthography rules should be applies when adding | |||
There was a problem hiding this comment.
Not really related to this pull request, but there's a typo in the variable name in this line of the docstring.
TheaMorin
approved these changes
Nov 2, 2020
|
Added news and typo correction, please merge @benoit-pierre if you're okay with the wording. |
Even if the theory is not configured.
Don't strip initial "/".
benoit-pierre
force-pushed
the
add_support_for_prefix_strokes
branch
from
65a9b1c to
3a76e3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Prefix strokes only match at the beginning of a word: this is useful for orthographic theories with explicit spacing (like Melani).
Needed for #987.
Pull Request Checklist