Update autoscaling to use service override #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deydra71
added a commit
to Deydra71/openstack-operator
that referenced
this pull request
Mar 7, 2024
Creates certs for k8s service of the service operator when
spec.tls.endpoint.internal.enabled: true
For a service like nova which talks to multiple service internal
endpoints, this has to be set for each of them for, like:
~~~
customServiceConfig: |
[keystone_authtoken]
insecure = true
[placement]
insecure = true
[neutron]
insecure = true
[glance]
insecure = true
[cinder]
insecure = true
~~~
Depends-On: openstack-k8s-operators/lib-common#428
Depends-On: openstack-k8s-operators#620
Depends-On: openstack-k8s-operators/telemetry-operator#310
Depends-On: openstack-k8s-operators/telemetry-operator#327
Depends-On: openstack-k8s-operators/telemetry-operator#330
Signed-off-by: Veronika Fisarova <[email protected]>
Deydra71
added a commit
to Deydra71/openstack-operator
that referenced
this pull request
Mar 7, 2024
Creates the telemetry aodh route and svc overrides.
Creates certs for k8s service of the service operator when
spec.tls.endpoint.internal.enabled: true
For a service like nova which talks to multiple service internal
endpoints, this has to be set for each of them for, like:
~~~
customServiceConfig: |
[keystone_authtoken]
insecure = true
[placement]
insecure = true
[neutron]
insecure = true
[glance]
insecure = true
[cinder]
insecure = true
~~~
Depends-On: openstack-k8s-operators/lib-common#428
Depends-On: openstack-k8s-operators#620
Depends-On: openstack-k8s-operators/telemetry-operator#310
Depends-On: openstack-k8s-operators/telemetry-operator#327
Depends-On: openstack-k8s-operators/telemetry-operator#330
Signed-off-by: Veronika Fisarova <[email protected]>
Deydra71
force-pushed
the
aodh-apioverride
branch
from
00e8a87 to
919ecce
Compare
Deydra71
force-pushed
the
aodh-apioverride
branch
from
919ecce to
18ab158
Compare
stuggi
reviewed
Mar 7, 2024
controllers/aodh_controller.go
Outdated
| svcOverride = &service.RoutedOverrideSpec{} | ||
|
|
||
| // Make sure the Service map in the Override is initialized | ||
| if instance.Spec.Aodh.Override.Service == nil { |
There was a problem hiding this comment.
wouldn't it be ok to do it like in the other operators? e.g. https://github.com/openstack-k8s-operators/ironic-operator/blob/main/controllers/ironicapi_controller.go#L427
There was a problem hiding this comment.
I see, on it, thanks!
Deydra71
force-pushed
the
aodh-apioverride
branch
3 times, most recently
from
b04ca6c to
880d13c
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Deydra71, vyzigold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/fc17a6edb35f45e9882db2e93f778eef ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 43s |
Signed-off-by: Veronika Fisarova <[email protected]>
Deydra71
force-pushed
the
aodh-apioverride
branch
from
880d13c to
7183475
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/a6d9fd65971046a98f193daa78cb814a ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 48s |
|
recheck |
|
/lgtm |
openshift-merge-bot
bot
merged commit 4ecd4f5
into
openstack-k8s-operators:main
6 checks passed
Deydra71
added a commit
to Deydra71/openstack-operator
that referenced
this pull request
Mar 11, 2024
Creates the telemetry aodh route and svc overrides.
Creates certs for k8s service of the service operator when
spec.tls.endpoint.internal.enabled: true
For a service like nova which talks to multiple service internal
endpoints, this has to be set for each of them for, like:
~~~
customServiceConfig: |
[keystone_authtoken]
insecure = true
[placement]
insecure = true
[neutron]
insecure = true
[glance]
insecure = true
[cinder]
insecure = true
~~~
Depends-On: openstack-k8s-operators/lib-common#428
Depends-On: openstack-k8s-operators#620
Depends-On: openstack-k8s-operators/telemetry-operator#310
Depends-On: openstack-k8s-operators/telemetry-operator#327
Depends-On: openstack-k8s-operators/telemetry-operator#330
Signed-off-by: Veronika Fisarova <[email protected]>
Deydra71
added a commit
to Deydra71/openstack-operator
that referenced
this pull request
Mar 11, 2024
Creates the telemetry aodh route and svc overrides.
Creates certs for k8s service of the service operator when
spec.tls.endpoint.internal.enabled: true
For a service like nova which talks to multiple service internal
endpoints, this has to be set for each of them for, like:
~~~
customServiceConfig: |
[keystone_authtoken]
insecure = true
[placement]
insecure = true
[neutron]
insecure = true
[glance]
insecure = true
[cinder]
insecure = true
~~~
Depends-On: openstack-k8s-operators/lib-common#428
Depends-On: openstack-k8s-operators#620
Depends-On: openstack-k8s-operators/telemetry-operator#310
Depends-On: openstack-k8s-operators/telemetry-operator#327
Depends-On: openstack-k8s-operators/telemetry-operator#330
Signed-off-by: Veronika Fisarova <[email protected]>
Deydra71
added a commit
to Deydra71/openstack-operator
that referenced
this pull request
Mar 11, 2024
Creates the telemetry aodh route and svc overrides.
Creates certs for k8s service of the service operator when
spec.tls.endpoint.internal.enabled: true
For a service like nova which talks to multiple service internal
endpoints, this has to be set for each of them for, like:
~~~
customServiceConfig: |
[keystone_authtoken]
insecure = true
[placement]
insecure = true
[neutron]
insecure = true
[glance]
insecure = true
[cinder]
insecure = true
~~~
Depends-On: openstack-k8s-operators/lib-common#428
Depends-On: openstack-k8s-operators#620
Depends-On: openstack-k8s-operators/telemetry-operator#310
Depends-On: openstack-k8s-operators/telemetry-operator#327
Depends-On: openstack-k8s-operators/telemetry-operator#330
Signed-off-by: Veronika Fisarova <[email protected]>
Deydra71
added a commit
to Deydra71/openstack-operator
that referenced
this pull request
Mar 12, 2024
Creates the telemetry aodh route and svc overrides.
Creates certs for k8s service of the service operator when
spec.tls.endpoint.internal.enabled: true
For a service like nova which talks to multiple service internal
endpoints, this has to be set for each of them for, like:
~~~
customServiceConfig: |
[keystone_authtoken]
insecure = true
[placement]
insecure = true
[neutron]
insecure = true
[glance]
insecure = true
[cinder]
insecure = true
~~~
Depends-On: openstack-k8s-operators/lib-common#428
Depends-On: openstack-k8s-operators#620
Depends-On: openstack-k8s-operators/telemetry-operator#310
Depends-On: openstack-k8s-operators/telemetry-operator#327
Depends-On: openstack-k8s-operators/telemetry-operator#330
Signed-off-by: Veronika Fisarova <[email protected]>
Deydra71
added a commit
to Deydra71/openstack-operator
that referenced
this pull request
Mar 12, 2024
Creates the telemetry aodh route and svc overrides.
Creates certs for k8s service of the service operator when
spec.tls.endpoint.internal.enabled: true
For a service like nova which talks to multiple service internal
endpoints, this has to be set for each of them for, like:
~~~
customServiceConfig: |
[keystone_authtoken]
insecure = true
[placement]
insecure = true
[neutron]
insecure = true
[glance]
insecure = true
[cinder]
insecure = true
~~~
Depends-On: openstack-k8s-operators/lib-common#428
Depends-On: openstack-k8s-operators#620
Depends-On: openstack-k8s-operators/telemetry-operator#310
Depends-On: openstack-k8s-operators/telemetry-operator#327
Depends-On: openstack-k8s-operators/telemetry-operator#330
Signed-off-by: Veronika Fisarova <[email protected]>
Deydra71
added a commit
to Deydra71/openstack-operator
that referenced
this pull request
Mar 13, 2024
Creates the telemetry aodh route and svc overrides.
Creates certs for k8s service of the service operator when
spec.tls.endpoint.internal.enabled: true
For a service like nova which talks to multiple service internal
endpoints, this has to be set for each of them for, like:
~~~
customServiceConfig: |
[keystone_authtoken]
insecure = true
[placement]
insecure = true
[neutron]
insecure = true
[glance]
insecure = true
[cinder]
insecure = true
~~~
Depends-On: openstack-k8s-operators/lib-common#428
Depends-On: openstack-k8s-operators#620
Depends-On: openstack-k8s-operators/telemetry-operator#310
Depends-On: openstack-k8s-operators/telemetry-operator#327
Depends-On: openstack-k8s-operators/telemetry-operator#330
Signed-off-by: Veronika Fisarova <[email protected]>
Deydra71
added a commit
to Deydra71/openstack-operator
that referenced
this pull request
Mar 14, 2024
Creates the telemetry aodh route and svc overrides.
Creates certs for k8s service of the service operator when
spec.tls.endpoint.internal.enabled: true
For a service like nova which talks to multiple service internal
endpoints, this has to be set for each of them for, like:
~~~
customServiceConfig: |
[keystone_authtoken]
insecure = true
[placement]
insecure = true
[neutron]
insecure = true
[glance]
insecure = true
[cinder]
insecure = true
~~~
Depends-On: openstack-k8s-operators/lib-common#428
Depends-On: openstack-k8s-operators#620
Depends-On: openstack-k8s-operators/telemetry-operator#310
Depends-On: openstack-k8s-operators/telemetry-operator#327
Depends-On: openstack-k8s-operators/telemetry-operator#330
Signed-off-by: Veronika Fisarova <[email protected]>
Deydra71
added a commit
to Deydra71/openstack-operator
that referenced
this pull request
Mar 14, 2024
Creates the telemetry aodh route and svc overrides.
Creates certs for k8s service of the service operator when
spec.tls.endpoint.internal.enabled: true
For a service like nova which talks to multiple service internal
endpoints, this has to be set for each of them for, like:
~~~
customServiceConfig: |
[keystone_authtoken]
insecure = true
[placement]
insecure = true
[neutron]
insecure = true
[glance]
insecure = true
[cinder]
insecure = true
~~~
Depends-On: openstack-k8s-operators/lib-common#428
Depends-On: openstack-k8s-operators#620
Depends-On: openstack-k8s-operators/telemetry-operator#310
Depends-On: openstack-k8s-operators/telemetry-operator#327
Depends-On: openstack-k8s-operators/telemetry-operator#330
Signed-off-by: Veronika Fisarova <[email protected]>
stuggi
pushed a commit
to stuggi/openstack-operator
that referenced
this pull request
Apr 9, 2024
Creates the telemetry aodh route and svc overrides.
Creates certs for k8s service of the service operator when
spec.tls.endpoint.internal.enabled: true
For a service like nova which talks to multiple service internal
endpoints, this has to be set for each of them for, like:
~~~
customServiceConfig: |
[keystone_authtoken]
insecure = true
[placement]
insecure = true
[neutron]
insecure = true
[glance]
insecure = true
[cinder]
insecure = true
~~~
Depends-On: openstack-k8s-operators/lib-common#428
Depends-On: openstack-k8s-operators#620
Depends-On: openstack-k8s-operators/telemetry-operator#310
Depends-On: openstack-k8s-operators/telemetry-operator#327
Depends-On: openstack-k8s-operators/telemetry-operator#330
Signed-off-by: Veronika Fisarova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.