use Eventually in RunURLAssertSuite test #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RunURLAssertSuite harness currently waits on finalizers added to MariaDBAccount as an indication when it's safe to test that the new URL is present in the config. however, in [1] we are discussing removing the use of finalizers here so that this harness can be generalized to more kinds of controllers. as such, if the assertion here uses Eventually, it becomes compatible with this change, as the waiting for the condition is implemented directly here. [1] openstack-k8s-operators/mariadb-operator#205 (review)
zzzeek
force-pushed
the
use_eventually_test
branch
from
12e97e3 to
0a11ce9
Compare
gibizer
reviewed
Mar 7, 2024
gibizer
approved these changes
Mar 7, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gibizer, zzzeek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 970ded0
into
openstack-k8s-operators:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RunURLAssertSuite harness currently waits on finalizers added to MariaDBAccount as an indication when it's safe to test that the new URL is present in the config. however, in [1] we are discussing removing the use of finalizers here so that this harness can be generalized to more kinds of controllers. as such, if the assertion here uses Eventually, it becomes compatible with this change, as the waiting for the condition is implemented directly here.
[1]
openstack-k8s-operators/mariadb-operator#205 (review)