Add PlacementAPISpecCore struct #169
Conversation
This version of the struct (called "core") is meant to be used via the OpenStackControlplane. It is the same as PlacementAPISpec only it is missing the containerImages. The Default() function for webhooks has been split accordingly. Jira: OSPRH-4835
There was a problem hiding this comment.
I'm ok with this patch, but I will wait for @gibizer review
| @@ -121,18 +126,27 @@ func (r *PlacementAPI) ValidateDelete() (admission.Warnings, error) { | |||
| } | |||
|
|
|||
| func (r PlacementAPISpec) ValidateCreate(basePath *field.Path) field.ErrorList { | |||
There was a problem hiding this comment.
note to myself: This is called by the webhook within the placement-operator via func (r *PlacementAPI) ValidateCreate()
| return ValidateDefaultConfigOverwrite(basePath, r.DefaultConfigOverwrite) | ||
| } | ||
|
|
||
| func (r PlacementAPISpecCore) ValidateCreate(basePath *field.Path) field.ErrorList { |
There was a problem hiding this comment.
note to myself: this will be called by the webhook in openstack-operator when validating the service core struct within the openstackcontrolplane struct.
| func (r PlacementAPISpec) ValidateDefaultConfigOverwrite( | ||
| func ValidateDefaultConfigOverwrite( |
There was a problem hiding this comment.
An alternative would be to change this to use the PlacementAPISpecCore as a receiver. Then
func (r PlacementAPISpecCore) ValidateCreatecan call it directly as the type matchesfunc (r PlacementAPISpec) ValidateCreatecan call it on its internal core struct within its receiver. Golang actually expose the functions on the embedded struct on the embedding struct automatically.
There was a problem hiding this comment.
This would reduce the change to gibizer@91e9a07
While this is not a big deal here in placement, I think if we apply this pattern to the nova PR that would reduce the change there significantly
There was a problem hiding this comment.
Applying it to nova is not a clear cut due to deeper nesting of structs without a common embedded base struct.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince, gibizer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 0bd583d
into
openstack-k8s-operators:main
This version of the struct (called "core") is meant to be used via the OpenStackControlplane. It is the same as PlacementAPISpec only it is missing the containerImages.
The Default() function for webhooks has been split accordingly.
Jira: OSPRH-4835