Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller runtime v0.16.4 Go 1.20 #151

Merged
merged 6 commits into from
Feb 14, 2024

Conversation

gibizer
Copy link
Collaborator

@gibizer gibizer commented Feb 14, 2024

No description provided.

gibizer and others added 6 commits February 14, 2024 13:23
This change updates the webhook functions to comply with the new
standard for controller-runtime.

Signed-off-by: Brendan Shephard <[email protected]>
This change updates the manager intialisation to comply with the new controller-runtime schema.

Signed-off-by: Brendan Shephard <[email protected]>
This change fixes the Watches declarations to comply with the new
controller-runtime standards

Signed-off-by: Brendan Shephard <[email protected]>
@gibizer gibizer requested a review from bshephar February 14, 2024 12:31
@openshift-ci openshift-ci bot requested review from kk7ds and viroel February 14, 2024 12:31
Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

@gibizer: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional 3392960 link true /test functional
ci/prow/precommit-check 3392960 link true /test precommit-check
ci/prow/placement-operator-build-deploy-kuttl 3392960 link true /test placement-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gibizer
Copy link
Collaborator Author

gibizer commented Feb 14, 2024

We need to force merge all the bump to get back to green CI state.

@gibizer gibizer merged commit 461276b into openstack-k8s-operators:main Feb 14, 2024
2 of 6 checks passed
ASBishop pushed a commit to ASBishop/glance-operator that referenced this pull request Feb 22, 2024
As done for nova [1] we need to run 'go mod tidy' on both the root of
the repo and in the api/ to make sure we're able to update both mod
files.

[1] openstack-k8s-operators/placement-operator#151

Signed-off-by: Francesco Pantano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants