Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go.mod]Bump from v0.3.0 to pseudoversion #288

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Jan 26, 2024

Our intention is to track service operator and lib-common dependencies via pseudoversions. However renovate does not automatically bump from a tagged version (e.g. v0.3.0) to a newer but not tagged pseudoversion. So this patch does the manual bump. After this renovate will bump the newer pseduoversions.

@gibizer gibizer requested a review from dprince January 26, 2024 11:51
@openshift-ci openshift-ci bot requested review from abays and lewisdenny January 26, 2024 11:51
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/8cdc1f8b612d4256b76a4bf172860b8f

openstack-k8s-operators-content-provider FAILURE in 8m 16s

@gibizer gibizer force-pushed the bump-to-pseudoversion branch from b6dcf62 to cb0ef17 Compare January 26, 2024 12:20
@booxter
Copy link
Contributor

booxter commented Jan 29, 2024

The kuttl failure may be relevant, I see neutron-db-create failing with

ERROR 1115 (42000) at line 1: Unknown character set: ''

@booxter
Copy link
Contributor

booxter commented Jan 29, 2024

The failure is probably related to https://github.com/openstack-k8s-operators/mariadb-operator/pull/172/files that added support for charsets for databases. But it's supposed to default to utf8, but the output suggests it's "".

@booxter
Copy link
Contributor

booxter commented Jan 29, 2024

Looks like gibi has some details about the failure captured here: openstack-k8s-operators/nova-operator#660 (comment) AFAIU the solution is to pull a newer mariadb-operator into openstack-operator. Perhaps it's already done? I will recheck here and see if it's solved then.

@booxter
Copy link
Contributor

booxter commented Jan 29, 2024

/retest

@booxter
Copy link
Contributor

booxter commented Jan 30, 2024

/lgtm

Our intention is to track service operator and lib-common dependencies
via pseudoversions. However renovate does not automatically bump from a
tagged version (e.g. v0.3.0) to a newer but not tagged pseudoversion. So
this patch does the manual bump. After this renovate will bump the newer
pseduoversions.
@openshift-ci openshift-ci bot added the lgtm label Feb 2, 2024
Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, slawqo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 004d76d into openstack-k8s-operators:main Feb 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants