Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go work sync to gowork make target #39

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Conversation

weinimo
Copy link
Contributor

@weinimo weinimo commented Apr 17, 2023

This will ensure that the go.mod files in the root and in ./api will not have different versions from the same dependency. Such divergence known to cause troubles when generating manifests in different environments.

@weinimo weinimo requested review from abays, dkehn and kajinamit April 17, 2023 13:39
@openshift-ci openshift-ci bot requested review from johnsom and viroel April 17, 2023 13:40
@viroel
Copy link
Contributor

viroel commented Apr 17, 2023

failed in pre-commit with timeout [1].
Can you try adding --timeout=5m in golangci-lint target in Makefile[2]?
This may fix pre-commit in this PR while @bshewale updates golanci config in another PR[3]

[1] https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openstack-k8s-operators_designate-operator/39/pull-ci-openstack-k8s-operators-designate-operator-main-precommit-check/1647962616804413440/artifacts/test/build-log.txt
[2]

$(LOCALBIN)/golangci-lint run --fix

[3] #37

This will ensure that the go.mod files in the root and in ./api will not
have different versions from the same dependency. Such divergence known
to cause troubles when generating manifests in different environments.
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, weinimo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 713529c into main Apr 17, 2023
@dkehn dkehn deleted the makefile-sync branch April 27, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants