Add NsRecords API fields under designateAPI #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omersch381 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
omersch381
force-pushed
the
add_ns_records_api_fields
branch
from
5496de7 to
f379cb9
Compare
So far we were using ns_records configmap to configure the pools ns records. This patch adds the NsRecords API field as in the near future we plan to switch to those instead of configmaps.
omersch381
force-pushed
the
add_ns_records_api_fields
branch
from
a66a86e to
4840fb9
Compare
openshift-merge-bot
bot
merged commit 962a5cb
into
openstack-k8s-operators:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we were using ns_records configmap to configure the pools ns records.
This patch adds the NsRecords API field as in the near future we plan to switch to those instead of configmaps.