-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adoption_osp_deploy : br-baremetal ovs_bridge #2697
base: main
Are you sure you want to change the base?
adoption_osp_deploy : br-baremetal ovs_bridge #2697
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look good to me
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hjensas Hey mate, could you please explain in your commit message why this change is needed? I interested to know if this was causing an issue or just better aligns with how customers have their br-baremetal bridge configured.
862cf80
to
da2cbda
Compare
New changes are detected. LGTM label has been removed. |
Yes, Done! |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/74a70399edc04084b62543f9d1ef0175 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 50m 40s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/636d56490d274aa0993592188cbb834d ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 58m 52s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/34e8f4c452d547089515bf49507d3b7f ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 09s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/14ad65871af3422abf5e064fa4fc7428 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 30m 03s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7880a23bc42d43919dc9e36269605d42 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 56s |
Change the NIC config template for OSP 17.1 deployment to use a ovs_bridge for the br-baremetal interface. Fixes issues in OVS wiring, when using linux bridge the patch to br-int was not created and tap interfaces (qdhcp) was not correctly wired. This also aligns the configuration used with the documentation.
da2cbda
to
868e3ca
Compare
Change the NIC config template for OSP 17.1 deployment to use a ovs_bridge for the br-baremetal interface.
Fixes issues in OVS wiring, when using linux bridge the patch to br-int
was not created and tap interfaces (qdhcp) was not correctly wired.
This also aligns the configuration used with the documentation. (docs.redhat.com)