Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adoption_osp_deploy : br-baremetal ovs_bridge #2697

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hjensas
Copy link
Contributor

@hjensas hjensas commented Jan 30, 2025

Change the NIC config template for OSP 17.1 deployment to use a ovs_bridge for the br-baremetal interface.

Fixes issues in OVS wiring, when using linux bridge the patch to br-int
was not created and tap interfaces (qdhcp) was not correctly wired.

This also aligns the configuration used with the documentation. (docs.redhat.com)

@hjensas hjensas requested a review from a team as a code owner January 30, 2025 20:28
Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cescgina for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@ciecierski ciecierski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me

@ciecierski
Copy link
Contributor

/lgtm

Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hjensas Hey mate, could you please explain in your commit message why this change is needed? I interested to know if this was causing an issue or just better aligns with how customers have their br-baremetal bridge configured.

@hjensas hjensas force-pushed the adoption-use-ovs_bridge_ironic branch from 862cf80 to da2cbda Compare February 3, 2025 10:53
@openshift-ci openshift-ci bot removed the lgtm label Feb 3, 2025
Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

New changes are detected. LGTM label has been removed.

@hjensas
Copy link
Contributor Author

hjensas commented Feb 3, 2025

@hjensas Hey mate, could you please explain in your commit message why this change is needed? I interested to know if this was causing an issue or just better aligns with how customers have their br-baremetal bridge configured.

Yes, Done!

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/74a70399edc04084b62543f9d1ef0175

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 50m 40s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 08m 54s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 35m 45s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 39s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 14s
✔️ build-push-container-cifmw-client SUCCESS in 17m 14s

@hjensas
Copy link
Contributor Author

hjensas commented Feb 3, 2025

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/636d56490d274aa0993592188cbb834d

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 58m 52s
podified-multinode-edpm-deployment-crc FAILURE in 1h 37m 09s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 22m 14s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 06s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 50s
✔️ build-push-container-cifmw-client SUCCESS in 17m 37s

@hjensas
Copy link
Contributor Author

hjensas commented Feb 4, 2025

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/34e8f4c452d547089515bf49507d3b7f

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 09s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 53s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 28m 27s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 15s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 39s
✔️ build-push-container-cifmw-client SUCCESS in 17m 36s

@hjensas
Copy link
Contributor Author

hjensas commented Feb 4, 2025

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/14ad65871af3422abf5e064fa4fc7428

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 30m 03s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 21s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 16m 32s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 11s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 42s
✔️ build-push-container-cifmw-client SUCCESS in 18m 30s

@hjensas
Copy link
Contributor Author

hjensas commented Feb 5, 2025

recheck

@hjensas hjensas requested a review from a team February 5, 2025 15:16
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7880a23bc42d43919dc9e36269605d42

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 56s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 29s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 30m 03s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 25s
cifmw-pod-pre-commit NODE_FAILURE Node request 100-0007756742 failed in 0s
✔️ build-push-container-cifmw-client SUCCESS in 23m 09s

Change the NIC config template for OSP 17.1 deployment to use a
ovs_bridge for the br-baremetal interface.

Fixes issues in OVS wiring, when using linux bridge the patch to br-int
was not created and tap interfaces (qdhcp) was not correctly wired.

This also aligns the configuration used with the documentation.
@hjensas hjensas force-pushed the adoption-use-ovs_bridge_ironic branch from da2cbda to 868e3ca Compare February 6, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants