Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Fix ipv6 condition #2682

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gthiemonge
Copy link

No description provided.

Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign frenzyfriday for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5172945efa9f4e5a800f969a96abb859

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 44m 59s
podified-multinode-edpm-deployment-crc FAILURE in 1h 29m 21s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 18m 28s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 59s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 39s
✔️ build-push-container-cifmw-client SUCCESS in 17m 28s
✔️ cifmw-molecule-libvirt_manager SUCCESS in 30m 00s
✔️ cifmw-molecule-reproducer SUCCESS in 14m 38s

ternary(ansible_facts[_name].ipv6 |
selectattr('scope', 'equalto', 'global') | first, {})
}}
{% if ansible_facts[_name].ipv6 is defined -%}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What issue are you fixing?

There is no information in the commit message, no link to issue/jira ticket explaining what the problem is.
To me, it looks like you are doing the same thing using a different "style"? If there was a commit message explaining what/why I probably would not have needed to ask these questions. :)

Copy link
Author

@gthiemonge gthiemonge Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just a DNM patch that tries to fix an issue I have in my env.
It looks like the syntax: "var is defined| ternary(var, other_var)" is not correct because ternary always evaluates both parameters.
The patch works for me now, but I'm not sure it covers all the cases
I'll remove the DNM tag if I find a clear/better solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants