OPENSSL_hexstr2buf_ex(): Handle zero-length input correctly #24770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t8m
added
branch: master
In case of zero-length input the code wrote one byte before the start of the output buffer. The length of the output was also reported incorrectly in this case.
github-actions
bot
added
the
severity: fips change
|
Shouldn't we just return an error on a zero length input? |
t-j-h
approved these changes
Jul 1, 2024
Why? Also OPENSSL_buf2hexstr() below returns an empty string in such case. |
nhorman
approved these changes
Jul 1, 2024
t8m
added
approval: done
shahsb
approved these changes
Jul 2, 2024
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to all the active branches. Thank you for the reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
Jul 2, 2024
In case of zero-length input the code wrote one byte before the start of the output buffer. The length of the output was also reported incorrectly in this case. Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Neil Horman <[email protected]> (Merged from #24770) (cherry picked from commit 3f7b355)
openssl-machine
pushed a commit
that referenced
this pull request
Jul 2, 2024
In case of zero-length input the code wrote one byte before the start of the output buffer. The length of the output was also reported incorrectly in this case. Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Neil Horman <[email protected]> (Merged from #24770) (cherry picked from commit 3f7b355)
openssl-machine
pushed a commit
that referenced
this pull request
Jul 2, 2024
In case of zero-length input the code wrote one byte before the start of the output buffer. The length of the output was also reported incorrectly in this case. Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Neil Horman <[email protected]> (Merged from #24770)
openssl-machine
pushed a commit
that referenced
this pull request
Jul 2, 2024
In case of zero-length input the code wrote one byte before the start of the output buffer. The length of the output was also reported incorrectly in this case. Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Neil Horman <[email protected]> (Merged from #24770) (cherry picked from commit 3f7b355)
openssl-machine
pushed a commit
that referenced
this pull request
Jul 2, 2024
In case of zero-length input the code wrote one byte before the start of the output buffer. The length of the output was also reported incorrectly in this case. Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Neil Horman <[email protected]> (Merged from #24770) (cherry picked from commit 3f7b355)
eclipse-oniro-oh-bot
pushed a commit
to eclipse-oniro-mirrors/third_party_openssl
that referenced
this pull request
Jul 9, 2024
In case of zero-length input the code wrote one byte before the start of the output buffer. The length of the output was also reported incorrectly in this case. Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Neil Horman <[email protected]> (Merged from openssl/openssl#24770) (cherry picked from commit 3f7b355733407cf777bfad5ce5b79610588bacc5) Signed-off-by: hhhFun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of zero-length input the code wrote one byte before the start of the output buffer. The length
of the output was also reported incorrectly in this case.