Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Provider compatibility on PR CI job #24537

Closed
wants to merge 1 commit into from
Closed

Add Provider compatibility on PR CI job #24537

wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented May 31, 2024 •
edited
Loading

This job will run only if extended tests label is set on the PR.

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: present The PR has suitable tests present branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 extended tests Run extended tests in CI labels May 31, 2024
@t8m t8m closed this May 31, 2024
@t8m t8m reopened this May 31, 2024
@t8m t8m force-pushed the prov-compat-on-pr branch 18 times, most recently from 671db17 to cfef383 Compare May 31, 2024 15:27
@t8m t8m force-pushed the prov-compat-on-pr branch 7 times, most recently from e3ad91e to af74d9b Compare May 31, 2024 15:49
@t8m t8m force-pushed the prov-compat-on-pr branch from af74d9b to 4e50454 Compare May 31, 2024 15:53
@t8m
Copy link
Member Author

t8m commented May 31, 2024

Please note that the 2 failing provider compat CI jobs have to be fixed on the 3.0 and 3.1 branches.

@t8m
Copy link
Member Author

t8m commented May 31, 2024

Also please note I want to add this workflow to all the branches so subsequent PRs on these branches can use this CI job.

@paulidale
Copy link
Contributor

This job will run only if extended tests label is set on the PR.

Which tests would get this?
Unless this is run often, we will fail to catch breaking changes. Such changes have appeared in all manner of different ways.

@t8m
Copy link
Member Author

t8m commented Jun 3, 2024

Which tests would get this?
Unless this is run often, we will fail to catch breaking changes. Such changes have appeared in all manner of different ways.

I do not plan to add the condition to extended tests to any existing tests that run on PRs (although it might make sense to add it for at least the self-hosted freebsd test which is flaky and we are unable to fix the flakiness). This is to be added for things like the Provider compat CI tests - which is being added by this PR.

@t8m
Copy link
Member Author

t8m commented Jun 21, 2024

ping @openssl/committers for second review

@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jun 21, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jun 22, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Jun 24, 2024
@t8m
Add Provider compatibility on PR CI job
94567d6 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
(Merged from #24537)
openssl-machine pushed a commit that referenced this pull request Jun 24, 2024
@t8m
Add Provider compatibility on PR CI job
7de0a33 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
(Merged from #24537)

(cherry picked from commit 94567d6)
@t8m
Copy link
Member Author

t8m commented Jun 24, 2024

Merged to all the active branches. Finally we can easily test provider compatibility on PRs on all branches.

openssl-machine pushed a commit that referenced this pull request Jun 24, 2024
@t8m
Add Provider compatibility on PR CI job
ac85b01 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
(Merged from #24537)

(cherry picked from commit 94567d6)
openssl-machine pushed a commit that referenced this pull request Jun 24, 2024
@t8m
Add Provider compatibility on PR CI job
4f797e0 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
(Merged from #24537)

(cherry picked from commit 94567d6)
openssl-machine pushed a commit that referenced this pull request Jun 24, 2024
@t8m
Add Provider compatibility on PR CI job
1c94b69 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
(Merged from #24537)

(cherry picked from commit 94567d6)
@t8m t8m closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulidale paulidale paulidale approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 extended tests Run extended tests in CI tests: present The PR has suitable tests present triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t8m @paulidale @openssl-machine @tom-cosgrove-arm