Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the latest FHIR SDK Artifacts #3211

Merged
merged 9 commits into from
Apr 23, 2024
Merged

Migrate to the latest FHIR SDK Artifacts #3211

merged 9 commits into from
Apr 23, 2024

Conversation

ndegwamartin
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3210

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 30.1%. Comparing base (ac82739) to head (fcf9495).
Report is 33 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3211     +/-   ##
=========================================
+ Coverage     29.6%   30.1%   +0.4%     
- Complexity     658     672     +14     
=========================================
  Files          239     239             
  Lines        11204   11259     +55     
  Branches      1948    1957      +9     
=========================================
+ Hits          3323    3394     +71     
+ Misses        7447    7422     -25     
- Partials       434     443      +9     
Flag Coverage Δ
engine 66.8% <0.0%> (+0.6%) ⬆️
geowidget 47.2% <ø> (ø)
quest 5.6% <ø> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 3.5% <ø> (ø)
...ore/engine/util/helper/TransformSupportServices.kt 71.8% <0.0%> (-2.4%) ⬇️

... and 5 files with indirect coverage changes

ndegwamartin and others added 3 commits April 20, 2024 15:34
* set up the file

* adds the intro part

* adds how to work with today function

* adds how to add dob as lower bound of date picker

* concludes

* update cqf expression documentation

* revert location change

* cleanup

---------

Co-authored-by: ageryck <[email protected]>
Co-authored-by: pld <[email protected]>
pld
pld previously approved these changes Apr 22, 2024
@pld pld enabled auto-merge (squash) April 22, 2024 19:36
@ndegwamartin
Copy link
Contributor Author

PR update now includes the FHIR SDK sync patch reorder patch by Aditya : google/android-fhir#2524

@pld pld merged commit 5d72b3e into main Apr 23, 2024
6 of 7 checks passed
@pld pld deleted the issue3210 branch April 23, 2024 16:47
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Add List Entry to Transform Services - StructureMap extraction

* Migrate Engine, SDC and Knowledger artifacts

* Test variable evaluation via cqf expressions (#3200)

* set up the file

* adds the intro part

* adds how to work with today function

* adds how to add dob as lower bound of date picker

* concludes

* update cqf expression documentation

* revert location change

* cleanup

---------

Co-authored-by: ageryck <[email protected]>
Co-authored-by: pld <[email protected]>

* Fix Build 💚

---------

Co-authored-by: Brandy <[email protected]>
Co-authored-by: ageryck <[email protected]>
Co-authored-by: pld <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to the latest FHIR SDK Artifacts
3 participants