Adds support for discarding an item before restoring it #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within a RestoreItemAction, if the Execute function sets abandonItem to true on the UpdatedItem before running it, then restoreResource skips any remaining actions on this item, skips restoring this item to the cluster, and continues on to the next item. In the plugin Execute function, the following line would trigger skipping, assuming input.Item is the object passed into NewRestoreItemActionExecuteOutput on return: unstructured.SetNestedField(input.Item.UnstructuredContent(), true, "abandonItem")
dymurray
reviewed
Mar 29, 2019
| @@ -700,6 +700,7 @@ func (ctx *context) restoreResource(resource, namespace, resourcePath string) (a | |||
| applicableActions = append(applicableActions, action) | |||
| } | |||
|
|
|||
| fileLoop: | |||
There was a problem hiding this comment.
Yes. I have to break out of two levels of loop, and using a named label is the only way of doing it in go. The only other way of doing it would be a significant refactoring of this (long) function.
dymurray
approved these changes
Mar 29, 2019
|
I think I'm going to submit an cleaner implementation that adds a new field to the output struct rather than embedding a coded message in the item itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within a RestoreItemAction, if the Execute function sets abandonItem
to true on the UpdatedItem before running it, then restoreResource
skips any remaining actions on this item, skips restoring this item
to the cluster, and continues on to the next item.
In the plugin Execute function, the following line would trigger
skipping, assuming input.Item is the object passed into
NewRestoreItemActionExecuteOutput on return: