-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-load-balancer: pre-install-rosa - create unique WAF ACLs #59728
aws-load-balancer: pre-install-rosa - create unique WAF ACLs #59728
Conversation
555ec20
to
265e76f
Compare
/hold The change makes sense. Unhold when ready to merge. |
/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-rosa-operator |
@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
265e76f
to
cc79c90
Compare
The classic WAF does not allow non alphanumeric characters in the name. |
/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-rosa-operator |
@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-rosa-operator |
@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/unhold |
/lgtm |
/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-rosa-operator |
@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-rosa-operator |
@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
cc79c90
to
3c7247b
Compare
/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-rosa-operator |
@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
3c7247b
to
9bd5387
Compare
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-rosa-operator |
@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse ack |
@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87, chiragkyal, DennisPeriquet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR tries to avoid sharing WAF ACLs between different PRs.