Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust qe aks owner #59724

Merged
merged 1 commit into from
Dec 11, 2024
Merged

adjust qe aks owner #59724

merged 1 commit into from
Dec 11, 2024

Conversation

heliubj18
Copy link
Contributor

@heliubj18 heliubj18 commented Dec 10, 2024 •
edited
Loading

replace fxie with heliubj18 for aks provision steps

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@heliubj18 heliubj18 marked this pull request as ready for review December 10, 2024 14:13
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2024
@heliubj18
Copy link
Contributor Author

@jianlinliu

@openshift-ci openshift-ci bot requested review from gpei and jianlinliu December 10, 2024 14:14
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 10, 2024
@heliubj18 heliubj18 mentioned this pull request Dec 10, 2024
Merged
@bryan-cox
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
jianlinliu
jianlinliu reviewed Dec 11, 2024
View reviewed changes
ci-operator/step-registry/aks/OWNERS
@@ -3,10 +3,10 @@ approvers:
- yunjiang29
- gpei
- jinyunma
- fxierh
- heliubj18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you also can drop installer team member from approvers and reviewers

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@heliubj18
Copy link
Contributor Author

heliubj18 commented Dec 11, 2024 •
edited
Loading

@jianlinliu I just dropped the installer qe members, thanks. Could you please review it again?

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@heliubj18: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@heliubj18: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jianlinliu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, heliubj18, jianlinliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3dd455e into openshift:master Dec 11, 2024
10 checks passed
yingzhanredhat pushed a commit to yingzhanredhat/release that referenced this pull request Dec 18, 2024
@heliubj18 @yingzhanredhat
adjust qe aks owner (openshift#59724)
09a0fec
yingzhanredhat pushed a commit to yingzhanredhat/release that referenced this pull request Dec 24, 2024
@heliubj18 @yingzhanredhat
adjust qe aks owner (openshift#59724)
698dbf6
krishvoor pushed a commit to krishvoor/release that referenced this pull request Jan 29, 2025
@heliubj18 @krishvoor
adjust qe aks owner (openshift#59724)
8961c0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianlinliu jianlinliu jianlinliu left review comments

@gpei gpei Awaiting requested review from gpei

Assignees

@jianlinliu jianlinliu

@bryan-cox bryan-cox

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heliubj18 @bryan-cox @openshift-ci-robot @jianlinliu