Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On board openshift/knative-client to use OpenShift CI #4026

Merged
merged 4 commits into from
Jun 18, 2019
Merged

On board openshift/knative-client to use OpenShift CI #4026

merged 4 commits into from
Jun 18, 2019

Conversation

navidshaikh
Copy link
Contributor

openshift/knative-client is the client/CLI for knative, this PR
on boards the client to use OpenShift CI and adds respective tests.

@openshift-ci-robot
Copy link
Contributor

Hi @navidshaikh. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 11, 2019
@praveenkumar
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2019
@navidshaikh
Copy link
Contributor Author

/retest

1 similar comment
@navidshaikh
Copy link
Contributor Author

/retest

matzew
matzew reviewed Jun 12, 2019
View reviewed changes
ci-operator/config/openshift/knative-client/openshift-knative-client-release-next.yaml Outdated
name: release-next
base_images:
base:
name: '4.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.1 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you generate these? check in the eventin / serving repos, we generate those files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the serving one, should bump to 4.1
https://github.com/openshift/knative-serving/blob/master/openshift/ci-operator/generate-ci-config.sh#L7

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still 4.0

@matzew
Copy link
Member

matzew commented Jun 12, 2019

are there no postsubmit hooks ?

@navidshaikh
Copy link
Contributor Author

are there no postsubmit hooks ?

Nope, probably we'll add one as needed later, want to get the setup in place ASAP.

@navidshaikh navidshaikh force-pushed the knative-client-onboarding branch from a557c04 to a00de4d Compare June 12, 2019 14:38
@navidshaikh
On board openshift/knative-client to use OpenShift CI
b0672bb 
 openshift/knative-client is the client/CLI for knative, this PR
 on boards the client to use OpenShift CI and adds respective tests.
@navidshaikh
Updates config to use OCP 4.1
06497f1
@navidshaikh navidshaikh force-pushed the knative-client-onboarding branch from a00de4d to 06497f1 Compare June 12, 2019 15:56
stevekuznetsov
stevekuznetsov reviewed Jun 12, 2019
View reviewed changes
ci-operator/config/openshift/knative-client/openshift-knative-client-release-next.yaml Outdated
name: release-next
base_images:
base:
name: '4.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still 4.0

@navidshaikh
Copy link
Contributor Author

/test pj-rehearse

@navidshaikh
Copy link
Contributor Author

Updated installing knative serving

@navidshaikh
Copy link
Contributor Author

/test pj-rehearse

@navidshaikh
Copy link
Contributor Author

Updated to source knative/test-infra and added missing knative-serving namespace

/test pj-rehearse

@navidshaikh
Copy link
Contributor Author

navidshaikh commented Jun 14, 2019 •
edited
Loading

@matzew @stevekuznetsov : thanks for review, updated the PR, PTAL.

markusthoemmes
markusthoemmes approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2019
@petr-muller
Copy link
Member

@navidshaikh I think you should also add the repo to be watched by Tide for automated merges ( around https://github.com/openshift/release/blob/master/cluster/ci/config/prow/config.yaml#L333).

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2019
@petr-muller
Copy link
Member

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, navidshaikh, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2019
@openshift-merge-robot openshift-merge-robot merged commit 9ffa851 into openshift:master Jun 18, 2019
@openshift-ci-robot
Copy link
Contributor

@navidshaikh: Updated the following 5 configmaps:

  • ci-operator-misc-configs configmap in namespace ci using the following files:
    • key openshift-knative-client-release-next.yaml using file ci-operator/config/openshift/knative-client/openshift-knative-client-release-next.yaml
    • key openshift-knative-client-release-v0.1.0.yaml using file ci-operator/config/openshift/knative-client/openshift-knative-client-release-v0.1.0.yaml
  • ci-operator-misc-configs configmap in namespace ci-stg using the following files:
    • key openshift-knative-client-release-next.yaml using file ci-operator/config/openshift/knative-client/openshift-knative-client-release-next.yaml
    • key openshift-knative-client-release-v0.1.0.yaml using file ci-operator/config/openshift/knative-client/openshift-knative-client-release-v0.1.0.yaml
  • job-config-misc configmap in namespace ci using the following files:
    • key openshift-knative-client-release-next-presubmits.yaml using file ci-operator/jobs/openshift/knative-client/openshift-knative-client-release-next-presubmits.yaml
    • key openshift-knative-client-release-v0.1.0-presubmits.yaml using file ci-operator/jobs/openshift/knative-client/openshift-knative-client-release-v0.1.0-presubmits.yaml
  • config configmap in namespace ci using the following files:
    • key config.yaml using file cluster/ci/config/prow/config.yaml
  • plugins configmap in namespace ci using the following files:
    • key plugins.yaml using file cluster/ci/config/prow/plugins.yaml

In response to this:

openshift/knative-client is the client/CLI for knative, this PR
on boards the client to use OpenShift CI and adds respective tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew left review comments

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@markusthoemmes markusthoemmes markusthoemmes approved these changes

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

@hongkailiu hongkailiu Awaiting requested review from hongkailiu

Assignees

@petr-muller petr-muller

@markusthoemmes markusthoemmes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@navidshaikh @openshift-ci-robot @praveenkumar @matzew @petr-muller @markusthoemmes @stevekuznetsov @openshift-merge-robot