Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pre-commit job for cinder-operator #35864

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Added pre-commit job for cinder-operator #35864

merged 1 commit into from
Apr 6, 2023

Conversation

amolkahat
Copy link
Contributor

@amolkahat amolkahat commented Jan 31, 2023 •
edited
Loading

This patch adds pre-commit job for cinder
operator on prow.

Depends-on: openstack-k8s-operators/cinder-operator#147

@openshift-ci openshift-ci bot requested review from dprince and stuggi January 31, 2023 08:08
@openshift-ci-robot
Copy link
Contributor

@amolkahat, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR: 'could not load ci-operator configs from tested revision of release repo: %!w()'.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

Hi @amolkahat. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@amolkahat
Copy link
Contributor Author

/pj-rehearse pull-ci-openstack-k8s-operators-cinder-operator-master-precommit-check

@Sandeepyadav93
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2023
@amolkahat amolkahat force-pushed the cinder_operator_pre_commit_job branch 3 times, most recently from 94f7a71 to 8c6f820 Compare February 3, 2023 06:16
@Sandeepyadav93
Copy link
Contributor

/ph-rehearse

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2023
@amolkahat amolkahat force-pushed the cinder_operator_pre_commit_job branch from 8c6f820 to 4246cbf Compare February 10, 2023 08:49
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2023
@amolkahat
Copy link
Contributor Author

/ph-rehearse

@amolkahat amolkahat force-pushed the cinder_operator_pre_commit_job branch from 4246cbf to 5a0525c Compare February 14, 2023 11:17
@amolkahat
Copy link
Contributor Author

/pj-rehearse

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2023
@amolkahat amolkahat force-pushed the cinder_operator_pre_commit_job branch from 5a0525c to 0527ecc Compare February 20, 2023 08:32
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2023
@amolkahat
Copy link
Contributor Author

/pj-rehearse

@amolkahat amolkahat force-pushed the cinder_operator_pre_commit_job branch 3 times, most recently from 396f006 to 426ebd4 Compare February 22, 2023 18:03
@amolkahat
Copy link
Contributor Author

/pj-rehearse pull-ci-openstack-k8s-operators-cinder-operator-master-precommit-check

@amolkahat amolkahat force-pushed the cinder_operator_pre_commit_job branch 2 times, most recently from c0fe4a3 to 09f11c2 Compare February 27, 2023 10:33
@amolkahat
Copy link
Contributor Author

/pj-rehearse

@amolkahat amolkahat force-pushed the cinder_operator_pre_commit_job branch from e96b815 to dccdb6a Compare March 16, 2023 11:08
@rlandy
Copy link
Contributor

rlandy commented Mar 20, 2023

/pj-rehearse

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2023
@openshift-ci-robot
Copy link
Contributor

@rlandy, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR: 'couldn't rebase repo client'.

marios
marios reviewed Mar 21, 2023
View reviewed changes
Copy link
Contributor

@marios marios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks right but @amolkahat this needs a rebase can you please check

also does this need to depends-on openstack-k8s-operators/cinder-operator#147 (ie do we need to wait for that one before we merge this?)

@amolkahat amolkahat force-pushed the cinder_operator_pre_commit_job branch from dccdb6a to 1981f0a Compare March 21, 2023 09:33
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2023
@amolkahat
Copy link
Contributor Author

Thanks @marios , Updated description.

@amolkahat
Copy link
Contributor Author

/pj-rehearse

@marios
Copy link
Contributor

marios commented Mar 22, 2023 •
edited
Loading

Ack thanks for update @amolkahat ... looks like the -recommit-check job failed as expected, on the issue you are fixing in the depends-on

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/35864/rehearse-35864-pull-ci-openstack-k8s-operators-cinder-operator-master-precommit-check/1638147875894464512

hack/configure_local_webhook.sh:14:1: E003 Indent not multiple of 4
hack/configure_local_webhook.sh:15:1: E003 Indent not multiple of 4
hack/configure_local_webhook.sh:21:1: E003 Indent not multiple of 4
hack/configure_local_webhook.sh:23:1: E003 Indent not multiple of 4

which is fixed @ https://github.com/openstack-k8s-operators/cinder-operator/pull/147/files#diff-6cd5ffd3c66272b9abc4e8dc469dfb61b22aff6eaa00ac7e1f5985d8fa3116d3

So we need to hold on any more runs until that merges first

@marios marios mentioned this pull request Mar 22, 2023
Merged
@amolkahat amolkahat force-pushed the cinder_operator_pre_commit_job branch from 1981f0a to 4c609da Compare March 28, 2023 06:04
@bshewale bshewale force-pushed the cinder_operator_pre_commit_job branch from 4c609da to fde275b Compare April 3, 2023 11:09
@bshewale bshewale mentioned this pull request Apr 3, 2023
Closed
@viroel
Copy link
Contributor

viroel commented Apr 6, 2023

/retest-required

@viroel
Copy link
Contributor

viroel commented Apr 6, 2023

/pj-rehearse pull-ci-openstack-k8s-operators-cinder-operator-master-precommit-check

viroel
viroel suggested changes Apr 6, 2023
View reviewed changes
...k8s-operators/cinder-operator/openstack-k8s-operators-cinder-operator-master-presubmits.yaml Outdated
@@ -1,7 +1,7 @@
presubmits:
openstack-k8s-operators/cinder-operator:
- agent: kubernetes
always_run: false
always_run: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to stay as false

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bshewale can you fix this? missing this detail to merge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@amolkahat @bshewale
Added pre-commit job for cinder-operator
2c89a57 
This patch adds pre-commit job for cinder
operator on prow. And also removes the make
target hooks test. As we are going to use the
new way as revive as a replacement in [1]

[1]: openstack-k8s-operators/cinder-operator#147

Signed-off-by: Amol Kahat <[email protected]>
Co-authored-by: Bhagyashri Shewale <[email protected]>
@bshewale bshewale force-pushed the cinder_operator_pre_commit_job branch from fde275b to 2c89a57 Compare April 6, 2023 13:48
@viroel
Copy link
Contributor

viroel commented Apr 6, 2023

/pj-rehearse pull-ci-openstack-k8s-operators-cinder-operator-master-precommit-check

sanity check only

@viroel
Copy link
Contributor

viroel commented Apr 6, 2023

/lgtm

code looks good

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amolkahat, viroel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2023
@viroel
Copy link
Contributor

viroel commented Apr 6, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2023

@amolkahat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1c47da8 into openshift:master Apr 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2023

@amolkahat: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openstack-k8s-operators-cinder-operator-master.yaml using file ci-operator/config/openstack-k8s-operators/cinder-operator/openstack-k8s-operators-cinder-operator-master.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openstack-k8s-operators-cinder-operator-master-presubmits.yaml using file ci-operator/jobs/openstack-k8s-operators/cinder-operator/openstack-k8s-operators-cinder-operator-master-presubmits.yaml

In response to this:

This patch adds pre-commit job for cinder
operator on prow.

Depends-on: openstack-k8s-operators/cinder-operator#147

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marios marios marios left review comments

@bshewale bshewale bshewale left review comments

@viroel viroel viroel requested changes

@dprince dprince Awaiting requested review from dprince

@stuggi stuggi Awaiting requested review from stuggi

Assignees

@viroel viroel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@amolkahat @openshift-ci-robot @Sandeepyadav93 @rlandy @marios @viroel @bshewale @openshift-merge-robot