Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

external dns: release 1.0 config #35642

Merged
merged 1 commit into from
Feb 28, 2023
Merged

external dns: release 1.0 config #35642

merged 1 commit into from
Feb 28, 2023

Conversation

alebedev87
Copy link
Contributor

@alebedev87 alebedev87 commented Jan 24, 2023 •
edited
Loading

Follow up of #34949 (comment).

@openshift-ci-robot
Copy link
Contributor

@alebedev87: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-external-dns-operator-release-1.0-ci-index-external-dns-operator-bundle openshift/external-dns-operator presubmit Presubmit changed
pull-ci-openshift-external-dns-operator-release-1.0-e2e-aws-ovn-operator openshift/external-dns-operator presubmit Presubmit changed
pull-ci-openshift-external-dns-operator-release-1.0-e2e-azure-ovn-infoblox-operator openshift/external-dns-operator presubmit Presubmit changed
pull-ci-openshift-external-dns-operator-release-1.0-e2e-azure-ovn-operator openshift/external-dns-operator presubmit Presubmit changed
pull-ci-openshift-external-dns-operator-release-1.0-e2e-gcp-ovn-operator openshift/external-dns-operator presubmit Presubmit changed
pull-ci-openshift-external-dns-operator-release-1.0-images openshift/external-dns-operator presubmit Presubmit changed
pull-ci-openshift-external-dns-operator-release-1.0-unit openshift/external-dns-operator presubmit Presubmit changed
pull-ci-openshift-external-dns-operator-release-1.0-verify openshift/external-dns-operator presubmit Presubmit changed
pull-ci-openshift-external-dns-release-1.0-images openshift/external-dns presubmit Presubmit changed
pull-ci-openshift-external-dns-release-1.0-unit openshift/external-dns presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from frobware and knobunc January 24, 2023 14:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2023
@alebedev87
Copy link
Contributor Author

alebedev87 commented Jan 24, 2023 •
edited
Loading

/pj-rehearse

1 similar comment
@alebedev87
Copy link
Contributor Author

/pj-rehearse

@alebedev87
Copy link
Contributor Author

The infoblox test passed, the cluster was deprovisioned, it's just the lease which wasn't released correctly:

 INFO[2023-01-24T16:30:57Z] Releasing leases for test e2e-azure-ovn-infoblox-operator 
WARN[2023-01-24T16:30:59Z] Failed to update lease "eastus2--azure4-quota-slice-3"  error=status 502 Bad Gateway, status code 502 updating eastus2--azure4-quota-slice-3

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 24, 2023
@candita
Copy link
Contributor

candita commented Jan 25, 2023

/assign

@candita
Copy link
Contributor

candita commented Feb 1, 2023

The infoblox test passed, the cluster was deprovisioned, it's just the lease which wasn't released correctly:

 INFO[2023-01-24T16:30:57Z] Releasing leases for test e2e-azure-ovn-infoblox-operator 
WARN[2023-01-24T16:30:59Z] Failed to update lease "eastus2--azure4-quota-slice-3"  error=status 502 Bad Gateway, status code 502 updating eastus2--azure4-quota-slice-3

/pj-rehearse ack

@alebedev87 don't you need to get a passing result on the pj-rehearse? Even though it isn't "required", you still want to merge this with a failed ci/rehearse test?

@alebedev87
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-external-dns-operator-release-1.0-e2e-azure-ovn-infoblox-operator

@alebedev87
Copy link
Contributor Author

alebedev87 commented Feb 2, 2023 •
edited
Loading

@alebedev87 don't you need to get a passing result on the pj-rehearse? Even though it isn't "required", you still want to merge this with a failed ci/rehearse test?

The way I understand the idea of the pj-rehearse is that the hard dependency on the green tests is lifted. The CI config must be valid but is not forced to have the rehearsal all green. That may be helpful in case the rehearsal cannot be green (dependency on the code, etc.) or when the rehearsal is too nondeterministic (like a lot of NetEdge tests we saw recently) or when the failure was surely not related to the config change (like in this PR).

Just wanted to save some resources by not spinning another cluster but anyway I re-ran the failed test - it's all green now.

@candita
Copy link
Contributor

candita commented Feb 15, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9032cc0 and 2 for PR HEAD 6cbaca46e8f428cbbd9a1c0c623c3b7ecf359b04 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b060832 and 1 for PR HEAD 6cbaca46e8f428cbbd9a1c0c623c3b7ecf359b04 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9baa79d and 0 for PR HEAD 6cbaca46e8f428cbbd9a1c0c623c3b7ecf359b04 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 6cbaca46e8f428cbbd9a1c0c623c3b7ecf359b04 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023
@alebedev87
Copy link
Contributor Author

ci/prow/ordered-prow-config failed due to the build server change. No re-rehearsal is needed.

@alebedev87
Copy link
Contributor Author

Rebase from master.

@alebedev87
Copy link
Contributor Author

/pj-rehearse

@candita
Copy link
Contributor

candita commented Feb 27, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, candita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@candita
Copy link
Contributor

candita commented Feb 27, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2023
@openshift-merge-robot openshift-merge-robot merged commit e5da247 into openshift:master Feb 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@alebedev87: Updated the following 2 configmaps:

  • ci-operator-1.x-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-external-dns-operator-release-1.0.yaml using file ci-operator/config/openshift/external-dns-operator/openshift-external-dns-operator-release-1.0.yaml
    • key openshift-external-dns-release-1.0.yaml using file ci-operator/config/openshift/external-dns/openshift-external-dns-release-1.0.yaml
  • job-config-1.x configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-external-dns-operator-release-1.0-presubmits.yaml using file ci-operator/jobs/openshift/external-dns-operator/openshift-external-dns-operator-release-1.0-presubmits.yaml
    • key openshift-external-dns-release-1.0-postsubmits.yaml using file ci-operator/jobs/openshift/external-dns/openshift-external-dns-release-1.0-postsubmits.yaml
    • key openshift-external-dns-release-1.0-presubmits.yaml using file ci-operator/jobs/openshift/external-dns/openshift-external-dns-release-1.0-presubmits.yaml

In response to this:

Follow up of #34949 (comment).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frobware frobware Awaiting requested review from frobware

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@candita candita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alebedev87 @openshift-ci-robot @candita @openshift-merge-robot