Albo revert tag by commit

[alebedev87]

The tagging by commit to mirror using the wildcard was supposed to replace the custom logic in the mirror job. The custom logic was adding a tag for each image digest published on ALBO's quay.io organization. That, in turn, was a must to preserve the ALBO manifests which used those digests (dangling image digest are cleaned up).
However a tag for a commit is not enough as different branches may have the same Git commit but different image digests due to different base images, for example.

[openshift-ci-robot]

@alebedev87: the following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-aws-load-balancer-controller-openshift-release-0.2-images	openshift/aws-load-balancer-controller	presubmit	Ci-operator config changed
pull-ci-openshift-aws-load-balancer-controller-openshift-release-0.2-unit	openshift/aws-load-balancer-controller	presubmit	Ci-operator config changed
pull-ci-openshift-aws-load-balancer-controller-main-images	openshift/aws-load-balancer-controller	presubmit	Ci-operator config changed
pull-ci-openshift-aws-load-balancer-controller-main-unit	openshift/aws-load-balancer-controller	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[alebedev87]

/pj-rehearse skip

Mirroring doesn't impact CI config, tag_by_commit is optional and was useful only for the mirroring.

[alebedev87]

/hold

[alebedev87]

/unhold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, hongkailiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/aws-load-balancer-controller/OWNERS [alebedev87,hongkailiu]
• ci-operator/jobs/OWNERS [hongkailiu]
• core-services/image-mirroring/aws-load-balancer-operator/OWNERS [alebedev87,hongkailiu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@alebedev87: Updated the following 4 configmaps:

• image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:
  • key mapping_aws_load_balancer_operator using file core-services/image-mirroring/aws-load-balancer-operator/mapping_aws_load_balancer_operator
  • key mapping_aws_load_balancer_operator_0_2 using file core-services/image-mirroring/aws-load-balancer-operator/mapping_aws_load_balancer_operator_0_2
• ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
  • key openshift-aws-load-balancer-controller-main.yaml using file ci-operator/config/openshift/aws-load-balancer-controller/openshift-aws-load-balancer-controller-main.yaml
• ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
  • key openshift-aws-load-balancer-controller-openshift-release-0.2.yaml using file ci-operator/config/openshift/aws-load-balancer-controller/openshift-aws-load-balancer-controller-openshift-release-0.2.yaml
• job-config-misc configmap in namespace ci at cluster app.ci using the following files:
  • key infra-image-mirroring.yaml using file ci-operator/jobs/infra-image-mirroring.yaml

In response to this:

The tagging by commit to mirror using the wildcard was supposed to replace the custom logic in the mirror job. The custom logic was adding a tag for each image digest published on ALBO's quay.io organization. That, in turn, was a must to preserve the ALBO manifests which used those digests (dangling image digest are cleaned up).
However a tag for a commit is not enough as different branches may have the same Git commit but different image digests due to different base images, for example.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.