Modify install-config.yaml to use controlPlane and compute instead of master and worker #2787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
|
/hold Depends on openshift/installer#1157 |
openshift-ci-robot
added
the
do-not-merge/hold
… machines. In the cases where the replica count is not customizable, the controlPlane and compute have been removed to use the defaults for the machine pools. Update the apiVersion for install-config.yaml to v1beta3, which is the version that incorporates the controlPlane and compute fields. See openshift/installer#1157
staebler
force-pushed
the
install-config_controlplane-compute
branch
from
220d014 to
e1d729c
Compare
|
/hold cancel openshift/installer#1157 has been merged. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, sdodson, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@staebler: Updated the following 8 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Feb 26, 2019
When we pivoted to v1beta3 in ccdc32e (installconfig: separate control plane and compute machine pools, 2019-01-29, openshift#1157), we dropped support for the old 'machines' JSON property. Instead of silently ignoring that property in v1beta2 configs, error out to avoid surprising users later when they notice us not picking up their machines configuration. Or internal consumers pivoted to v1beta3 in openshift/release@e1d729c6 (Modify install-config.yaml to use controlPlane and compute instead of machines, 2019-02-05, openshift/release#2787) and openshift/hive@3eda6d12 (Bump to installer master branch, 2019-02-21, openshift/hive#228).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the cases where the replica count is not customizable, the controlPlane and compute have been removed to use the defaults for the machine pools.
Bump install-config.yaml apiVersion from
v1beta2tov1beta3.See openshift/installer#1157