Step addition: Pre-create CCM feature gate during cluster install

[Danil-Grigorev]

This step will allow to test functionality of CCM bootstrap, and install a cluster with pre-created feature gate. Such feature gate present in the cluster since the beginning of the cluster lifetime would allow TP cloud platforms to be installed, and prevent existing cloud providers (such as AWS, Azure, etc.) to ever use in-tree cloud-provider code.

Could be used after openshift/installer#4947 is merged.

[JoelSpeed]

Could you quickly explain how this is used? How is this different to the bootstrap step we already added?

[Danil-Grigorev]

@JoelSpeed The one we have now is not a bootstrap step, it is a migration of a fully ready cluster to CCM.

We will have a job which will reference this step before running openshift-install. (- chain: ipi-install)

Here is an example of similar step usage and a step definition

[Fedosin]

I think that if we deploy a new cluster, then we don't have to enable CSI migration, because there are no previously created volumes.

[Danil-Grigorev]

@Fedosin We do need it, as we want to run e2e tests on this cluster, and they include a lot of storage ones. CSI is a hard requirement for a cluster with CCM.

[elmiko]

this generally makes sense to me, i am curious how it fits into a ci run though. @Danil-Grigorev do you have another pr to followup and include this in a bootstrap job?

[Danil-Grigorev]

@elmiko Here is a followup PR (WIP) which shows how it would be used: https://github.com/openshift/release/compare/master...Danil-Grigorev:aws-ccm-install?expand=1

The usage is shown here: https://github.com/Danil-Grigorev/release/blob/93cbce2d69048f47ce4d46e7c05f664b57efdbb8/ci-operator/step-registry/openshift/e2e/aws/ccm/install/openshift-e2e-aws-ccm-install-workflow.yaml#L6-L7

[elmiko]

thanks for the example @Danil-Grigorev , it helps me understand =)
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Danil-Grigorev, elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ci-operator/step-registry/ccm/conf/OWNERS [Danil-Grigorev,elmiko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@Danil-Grigorev: Updated the step-registry configmap in namespace ci at cluster app.ci using the following files:

• key OWNERS using file ci-operator/step-registry/ccm/conf/pre-create-feature-gate/OWNERS
• key ccm-conf-pre-create-feature-gate-commands.sh using file ci-operator/step-registry/ccm/conf/pre-create-feature-gate/ccm-conf-pre-create-feature-gate-commands.sh
• key ccm-conf-pre-create-feature-gate-ref.metadata.json using file ci-operator/step-registry/ccm/conf/pre-create-feature-gate/ccm-conf-pre-create-feature-gate-ref.metadata.json
• key ccm-conf-pre-create-feature-gate-ref.yaml using file ci-operator/step-registry/ccm/conf/pre-create-feature-gate/ccm-conf-pre-create-feature-gate-ref.yaml

In response to this:

This step will allow to test functionality of CCM bootstrap, and install a cluster with pre-created feature gate. Such feature gate present in the cluster since the beginning of the cluster lifetime would allow TP cloud platforms to be installed, and prevent existing cloud providers (such as AWS, Azure, etc.) to ever use in-tree cloud-provider code.

Could be used after openshift/installer#4947 is merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.