Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added username to the maintainers list in OWNERS File #93

Merged

Conversation

devppratik
Copy link
Contributor

Added my GitHub username to the maintainers list in OWNERS File

@openshift-ci openshift-ci bot requested review from supreeth7 and T0MASD February 23, 2023 15:26
@openshift-ci
Copy link

openshift-ci bot commented Feb 23, 2023

@devppratik: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fahlmant
Copy link

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2023
@T0MASD
Copy link
Contributor

T0MASD commented Feb 27, 2023

Per per Supreeth, these are just placeholders for the time-being, maintainer role should be harmless as Prow really doesn't recognize it. I will clean this up in the following PR
/unhold
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devppratik, T0MASD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@openshift-merge-robot openshift-merge-robot merged commit abe4840 into openshift:main Feb 27, 2023
@devppratik devppratik deleted the maintainers-list-update branch February 27, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants