Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: View cluster service logs #130

Merged
merged 4 commits into from
May 2, 2023

Conversation

supreeth7
Copy link
Contributor

What type of PR is this?

Feature

What this PR does / Why we need it?

No more switching back and forth between kite and osdctl. This PR enables users to view an alerting cluster's service logs with a single click.

Which Jira/Github issue(s) does this PR fix?

Resolves: OSD-16135

Special notes for your reviewer

Prerequisites:-

  • You need to have OCM configured locally
  • Be logged into the relevant OCM environment (production)

Pre-checks (if applicable)

  • Ran unit tests locally against the changes
  • Included documentation changes with PR

@openshift-ci openshift-ci bot requested review from Dee-6777 and Deepanshu276 May 2, 2023 05:40
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #130 (9ffbe52) into main (c4a0e91) will decrease coverage by 0.90%.
The diff coverage is 5.26%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   14.40%   13.51%   -0.90%     
==========================================
  Files          22       23       +1     
  Lines        1305     1591     +286     
==========================================
+ Hits          188      215      +27     
- Misses       1096     1354     +258     
- Partials       21       22       +1     
Impacted Files Coverage Δ
pkg/ui/events.go 0.00% <0.00%> (ø)
pkg/ui/input.go 0.00% <0.00%> (ø)
pkg/ui/tui.go 0.00% <0.00%> (ø)
pkg/ocm/servicelog.go 12.12% <12.12%> (ø)

... and 3 files with indirect coverage changes

@supreeth7
Copy link
Contributor Author

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 2, 2023
@MitaliBhalla
Copy link
Contributor

MitaliBhalla commented May 2, 2023

Reviewed and tested, works super fine. Thanks for this work.

@MitaliBhalla
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MitaliBhalla, supreeth7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MitaliBhalla,supreeth7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented May 2, 2023

@supreeth7: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 9b246fb into openshift:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants