Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go-ovirt and run make vendor #55

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

Gal-Zaidman
Copy link

bumped go-ovirt version to the latest to consume:

  1. Align connection testing code with logic in Java/Python SDK  oVirt/ovirt-engine-sdk-go#217
  2. Check if response is not nil oVirt/ovirt-engine-sdk-go#215

Also ran make vendor which added protobuf

Signed-off-by: Gal-Zaidman [email protected]

bumped go-ovirt version to the latest to consume:
1. oVirt/ovirt-engine-sdk-go#217
2. oVirt/ovirt-engine-sdk-go#215

Also ran make vendor which added protobuf

Signed-off-by: Gal-Zaidman <[email protected]>
@openshift-merge-robot
Copy link

@Gal-Zaidman: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt fc04680 link /test e2e-ovirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bennyz
Copy link
Member

bennyz commented Nov 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bennyz, Gal-Zaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2020
@openshift-merge-robot openshift-merge-robot merged commit 609bf1a into openshift:master Nov 18, 2020
@Gal-Zaidman
Copy link
Author

/cherry-pick release-4.6

@openshift-cherrypick-robot

@Gal-Zaidman: new pull request created: #64

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants