Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.16] OCPBUGS-49835: Backport extensions/Dockerfile: Get extensions rpm list #1736

Open
wants to merge 2 commits into
base: release-4.16
Choose a base branch
from

Conversation

ravanelli
Copy link
Member

  • Generate JSON file listing installed extension packages;
  • Use dnf repoquery to list 'name: version,' for each RPM and generates a JSON file at /tmp/extensions.json. Where the build volume is mounted;
  • It is needed to generated the extensions package list in meta.json.

Signed-off-by: Renata Ravanelli [email protected]
(cherry picked from commit 128a6b9)

 - Generate JSON file listing installed extension packages;
 - Use dnf repoquery to list 'name: version,' for each RPM
and generates a JSON file at `/tmp/extensions.json`. Where the
build volume is mounted;
 - It is needed to generated the extensions package list in meta.json.

Signed-off-by: Renata Ravanelli <[email protected]>
(cherry picked from commit 128a6b9)
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2025
@mike-nguyen
Copy link
Member

/label backport-risk-assessed
/label cherry-pick-approved
/lgtm

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Feb 4, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2025
Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mike-nguyen, ravanelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mike-nguyen,ravanelli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ravanelli ravanelli changed the title [release-4.16] Backport extensions/Dockerfile: Get extensions rpm list [release-4.16] OCPBUGS-49835: Backport extensions/Dockerfile: Get extensions rpm list Feb 4, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 4, 2025
@openshift-ci-robot
Copy link

@ravanelli: This pull request references Jira Issue OCPBUGS-49835, which is invalid:

  • expected dependent Jira Issue OCPBUGS-49834 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • Generate JSON file listing installed extension packages;
  • Use dnf repoquery to list 'name: version,' for each RPM and generates a JSON file at /tmp/extensions.json. Where the build volume is mounted;
  • It is needed to generated the extensions package list in meta.json.

Signed-off-by: Renata Ravanelli [email protected]
(cherry picked from commit 128a6b9)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jlebon
Copy link
Member

jlebon commented Feb 4, 2025

/hold

Let's cherrypick #1737 too.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2025
`%{version}` just prints the version field, but we want the epoch,
release, and arch too. This matches what we previously would output
before moving extensions building to a container.

There is code that will parse this metadata assuming that it's an EVRA:

https://github.com/openshift-eng/art-tools/blob/6a29949b2b2819afe00829646e6c7db9b784ff8a/doozer/doozerlib/rhcos.py#L248
(cherry picked from commit 51e149d)
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2025
Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

New changes are detected. LGTM label has been removed.

@ravanelli
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2025
Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

@ravanelli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos-9-build-test-qemu ec1a742 link true /test rhcos-9-build-test-qemu

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants