Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17] OCPBUGS-49834: Backport extensions/Dockerfile: Get extensions rpm list #1734

Merged
merged 2 commits into from
Feb 6, 2025
Merged

[release-4.17] OCPBUGS-49834: Backport extensions/Dockerfile: Get extensions rpm list #1734

merged 2 commits into from
Feb 6, 2025
+10 −0

Conversation

ravanelli
Copy link
Member

  • Generate JSON file listing installed extension packages;
  • Use dnf repoquery to list 'name: version,' for each RPM and generates a JSON file at /tmp/extensions.json. Where the build volume is mounted;
  • It is needed to generated the extensions package list in meta.json.

Signed-off-by: Renata Ravanelli [email protected]
(cherry picked from commit 128a6b9)

@ravanelli
extensions/Dockerfile: Get extensions rpm list
de63b2b 
 - Generate JSON file listing installed extension packages;
 - Use dnf repoquery to list 'name: version,' for each RPM
and generates a JSON file at `/tmp/extensions.json`. Where the
build volume is mounted;
 - It is needed to generated the extensions package list in meta.json.

Signed-off-by: Renata Ravanelli <[email protected]>
(cherry picked from commit 128a6b9)
@openshift-ci openshift-ci bot requested review from cverna and HuijingHei February 3, 2025 14:54
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2025
@ravanelli ravanelli mentioned this pull request Feb 3, 2025
Open
@mike-nguyen
Copy link
Member

/retest

@mike-nguyen
Copy link
Member

/label backport-risk-assessed
/label cherry-pick-approved
/lgtm

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Feb 4, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2025
@ravanelli ravanelli changed the title [release-4.17] Backport extensions/Dockerfile: Get extensions rpm list [release-4.17] OCPBUGS-49834: Backport extensions/Dockerfile: Get extensions rpm list Feb 4, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 4, 2025
@openshift-ci-robot
Copy link

@ravanelli: This pull request references Jira Issue OCPBUGS-49834, which is invalid:

  • expected dependent Jira Issue OCPBUGS-49833 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • Generate JSON file listing installed extension packages;
  • Use dnf repoquery to list 'name: version,' for each RPM and generates a JSON file at /tmp/extensions.json. Where the build volume is mounted;
  • It is needed to generated the extensions package list in meta.json.

Signed-off-by: Renata Ravanelli [email protected]
(cherry picked from commit 128a6b9)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jlebon
Copy link
Member

jlebon commented Feb 4, 2025

/hold

Let's cherrypick #1737 too.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2025
@jlebon @ravanelli
extensions: include release and arch in extensions.json
e65aaa9 
`%{version}` just prints the version field, but we want the epoch,
release, and arch too. This matches what we previously would output
before moving extensions building to a container.

There is code that will parse this metadata assuming that it's an EVRA:

https://github.com/openshift-eng/art-tools/blob/6a29949b2b2819afe00829646e6c7db9b784ff8a/doozer/doozerlib/rhcos.py#L248
(cherry picked from commit 51e149d)
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2025
@ravanelli
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2025
@mike-nguyen
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

@mike-nguyen: This pull request references Jira Issue OCPBUGS-49834, which is invalid:

  • expected dependent Jira Issue OCPBUGS-49833 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

@ravanelli: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ravanelli
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

@ravanelli: This pull request references Jira Issue OCPBUGS-49834, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected dependent Jira Issue OCPBUGS-49833 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mike-nguyen
Copy link
Member

I have to verify that the extensions works. I'm just waiting on a build

@mike-nguyen
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 6, 2025
@openshift-ci-robot
Copy link

@mike-nguyen: This pull request references Jira Issue OCPBUGS-49834, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-49833 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-49833 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 6, 2025
@openshift-ci openshift-ci bot requested a review from mike-nguyen February 6, 2025 14:50
@mike-nguyen
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mike-nguyen, ravanelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mike-nguyen,ravanelli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 063b8ce into openshift:release-4.17 Feb 6, 2025
5 checks passed
@openshift-ci-robot
Copy link

@ravanelli: Jira Issue OCPBUGS-49834: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-49834 has been moved to the MODIFIED state.

In response to this:

  • Generate JSON file listing installed extension packages;
  • Use dnf repoquery to list 'name: version,' for each RPM and generates a JSON file at /tmp/extensions.json. Where the build volume is mounted;
  • It is needed to generated the extensions package list in meta.json.

Signed-off-by: Renata Ravanelli [email protected]
(cherry picked from commit 128a6b9)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cverna cverna Awaiting requested review from cverna

@HuijingHei HuijingHei Awaiting requested review from HuijingHei

@mike-nguyen mike-nguyen Awaiting requested review from mike-nguyen

Assignees

@mike-nguyen mike-nguyen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ravanelli @mike-nguyen @openshift-ci-robot @jlebon