Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to extend disk on AWS with NVMe #133

Closed
cgwalters opened this issue Jun 22, 2018 · 5 comments
Closed

Fails to extend disk on AWS with NVMe #133

cgwalters opened this issue Jun 22, 2018 · 5 comments
Assignees
@cgwalters

Comments

@cgwalters
Copy link
Member

We dropped cloud-init which has disk resizing code, and it turns out Ignition doesn't do this, see https://github.com/coreos/init/blob/master/scripts/extend-filesystems

Now the next problem we have is that script doesn't handle LVM...in practice what we did with Fedora Atomic was that it was actually container-storage-setup that does this, I need to figure out why that's not working.
@cgwalters cgwalters self-assigned this Jun 22, 2018
@cgwalters
Copy link
Member Author

OK, container-storage-setup.service isn't running because...docker.service isn't? And we're missing growpart. Fixing.

cgwalters added a commit to cgwalters/os that referenced this issue Jun 22, 2018
@cgwalters
host: Explicitly include container-storage-setup and growpart
dd0117a 
We lost `cloud-utils-growpart` when we dropped `cloud-init`.
Should help with openshift#133
although I haven't had time to test yet, but it's what we need to do now.
@cgwalters cgwalters mentioned this issue Jun 22, 2018
Merged
@cgwalters
Copy link
Member Author

Now tested, this fixed it.

@cgwalters
Copy link
Member Author

Fixed by #134

@cgwalters
Copy link
Member Author

cgwalters commented Jun 25, 2018 •
edited
Loading

The next problem here is:

# rpm-ostree status
...
● ostree://rhcos:openshift/3.10/x86_64/os
                   Version: 3.10-7.5.156 (2018-06-24 12:02:40)
...
# rpm -q container-storage-setup
container-storage-setup-0.9.0-1.rhel75.gite0997c3.el7.noarch
...
Jun 25 20:43:30 localhost.localdomain container-storage-setup[916]: Physical volume "/dev/nvme0n1p2" changed
Jun 25 20:43:30 localhost.localdomain container-storage-setup[916]: FAILED: /dev/nvme: does not exist

i.e. c-s-s falls over for NVMe. This was supposed to be fixed in projectatomic/container-storage-setup#138 (comment) but AFAICS that doesn't help.

More info: Booted via AWS console, expanded root disk to 42GB.

[root@ip-172-18-1-190 ~]# lsblk
NAME            MAJ:MIN RM  SIZE RO TYPE MOUNTPOINT
nvme0n1         259:0    0   42G  0 disk 
├─nvme0n1p1     259:1    0  300M  0 part /boot
└─nvme0n1p2     259:2    0  5.7G  0 part 
  └─coreos-root 253:0    0  5.7G  0 lvm  /sysroot
[root@ip-172-18-1-190 ~]# fdisk -l /dev/nvme0n1 

Disk /dev/nvme0n1: 45.1 GB, 45097156608 bytes, 88080384 sectors
Units = sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disk label type: dos
Disk identifier: 0x848519a5

        Device Boot      Start         End      Blocks   Id  System
/dev/nvme0n1p1   *        2048      616447      307200   83  Linux
/dev/nvme0n1p2          616448    12582911     5983232   8e  Linux LVM
[root@ip-172-18-1-190 ~]#

@cgwalters cgwalters changed the title Readd logic to extend rootfs Fails to extend disk on AWS with NVMe Jun 25, 2018
cgwalters added a commit to cgwalters/docker-storage-setup that referenced this issue Jun 26, 2018
@cgwalters
c-s-s: Support GROWPART=true on NVMe
4513db0 
By using sysfs, splitting device/partition is a lot more reliable.
This fixes using GROWPART=true on NVMe with Fedora Atomic Host,
as occurs in AWS with modern instance types.

Closes: openshift/os#133
@cgwalters cgwalters mentioned this issue Jun 26, 2018
Closed
@cgwalters
Copy link
Member Author

cgwalters commented Jun 27, 2018 •
edited
Loading

PR in projectatomic/container-storage-setup#275

After that lands though we need to keep this open to track actually cherry picking the fix.

cgwalters added a commit to cgwalters/docker-storage-setup that referenced this issue Jul 13, 2018
@cgwalters
c-s-s: Support GROWPART=true on NVMe
d4994e6 
By using sysfs, splitting device/partition is a lot more reliable.
This fixes using GROWPART=true on NVMe with Fedora Atomic Host,
as occurs in AWS with modern instance types.

Closes: openshift/os#133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgwalters cgwalters

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

c-s-s: Support GROWPART=true on NVMe cgwalters/docker-storage-setup
1 participant
@cgwalters