Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SA OAuth test flake #9841

Merged
merged 1 commit into from
Jul 14, 2016
Merged

Fix SA OAuth test flake #9841

merged 1 commit into from
Jul 14, 2016

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Jul 14, 2016

Change poll to retry on conflict, refetch each time in order to actually retry with new data

fixes #8701 (comment)

@liggitt
Copy link
Contributor Author

liggitt commented Jul 14, 2016

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to dea2566

@liggitt
Copy link
Contributor Author

liggitt commented Jul 14, 2016

@bparees PTAL

@smarterclayton
Copy link
Contributor

LGTM

@bparees
Copy link
Contributor

bparees commented Jul 14, 2016

lgtm too :)

@liggitt
Copy link
Contributor Author

liggitt commented Jul 14, 2016

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 14, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6253/) (Image: devenv-rhel7_4587)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to dea2566

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6253/)

@openshift-bot openshift-bot merged commit 5d153b2 into openshift:master Jul 14, 2016
@liggitt liggitt deleted the sa-test-flake branch July 14, 2016 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flake in TestSAAsOAuthClient
4 participants