Added debugging information to os::cmd output content test #9742
Conversation
| @@ -4,97 +4,97 @@ | |||
|
|
|||
| # expect_success runs the cmd and expects an exit code of 0 | |||
| function os::cmd::expect_success() { | |||
| if [[ $# -ne 1 ]]; then echo "os::cmd::expect_success expects only one argument, got $#"; exit 1; fi | |||
| local cmd=$1 | |||
| if [[ $# -ne 1 ]]; then echo "os::cmd::expect_success expects only one argument, got $#"; exit 1; fi | |||
There was a problem hiding this comment.
why spaces? tabs are better
There was a problem hiding this comment.
I can't quite remember where the original problems were, but when editors pick up that tabs are used in a file they default <tab> key to be '\t' ... and then everyone begins using tabs for alignment instead of only indentation. Since Bash is often really really annoying to look at without the correct alignment of things, this was a PITA for me. I agree that the best approach is tabs for indentation and spaces for alignment ... but in practice it doesn't seem like that's possible.
|
@liggitt WDYT? |
|
debugging commit looks fine |
Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/debug-output
branch
from
1a862b6 to
69a4085
Compare
|
[merge] |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 69a4085 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6274/) |
|
flake in e2e: while I search for the issue... @liggitt please re-tag? |
|
[merge] |
|
Evaluated for origin merge up to 69a4085 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6274/) (Image: devenv-rhel7_4594) |
First commit addresses tech debt, second adds debugging
@liggitt PTAL