Fix masterCA conversion #5051
Merged
Fix masterCA conversion #5051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deads2k PTAL |
|
[test] |
|
race #5025 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/5630/) |
|
Evaluated for origin test up to 33fb12b |
|
[merge] to fix master, will take comments as follow up |
|
race #5025 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3566/) (Image: devenv-fedora_2458) |
|
Evaluated for origin merge up to 33fb12b |
openshift-bot
pushed a commit
that referenced
this pull request
Oct 10, 2015
Merged by openshift-bot
| package api | ||
|
|
||
| func init() { | ||
| Scheme.AddDefaultingFuncs( |
There was a problem hiding this comment.
I didn't catch this in the previous review. Defaulters belong to versions. This would need to be in the v1/conversions.go with the rest of the defaulters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5050