Minor cleanups to sdn-cni-plugin

[danwinship]

Based on belated comments on #18355:

So what if we just stuff the PodIP into external-ids? Then we don't need to dump and parse flows all the time.

I had thought about that, but then we'd have to change ovs.Find() to return multiple columns (ofport and external-ids) and we'd have to parse the external-ids to separate out the sandboxID from the podIP. Though, admittedly, there's already code to parse external-ids in fake_ovs now anyway...

Also, we're only parsing a single flow now, because we request "in_port=%d" in the dump-flows.

Any reason to do [hostVeth] in the environment rather than just stuff it into the JSON by extending CNIRequest?

I actually did do it that way first, and then changed it. Something about adding a field to CNIRequest had weird unexpected side effects. IIRC, it would have required a whole bunch of changes to the unit tests or something like that.

But I can change it if you prefer.

[dcbw]

I actually did do it that way first, and then changed it. Something about adding a field to CNIRequest had weird unexpected side effects. IIRC, it would have required a whole bunch of changes to the unit tests or something like that.

@danwinship hmm, just doing:

	// CNI configuration passed via stdin to the CNI plugin
	Config []byte `json:"config,omitempty"`
+	HostVeth string `json:"config,omitempty"`
}

doesn't seem to kill unit tests in pkg/network for me...

[danwinship]

@dcbw: Hm... not sure what the problem was before, but yeah, it seems to work fine. Updated

[pravisankar]

/retest

[pravisankar]

LGTM

[dcbw]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/network/OWNERS [danwinship,dcbw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-robot]

Automatic merge from submit-queue (batch tested with PRs 18737, 18418).