Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy: verify the deployer SA has perms to update tags #15162

Merged
merged 1 commit into from
Aug 1, 2017
Merged

deploy: verify the deployer SA has perms to update tags #15162

merged 1 commit into from
Aug 1, 2017

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Jul 12, 2017

fixes: #10663

[test]

@mfojtik mfojtik force-pushed the deploy-check-ist-sar branch from 17aad36 to e9546e4 Compare July 12, 2017 12:12
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to e9546e4

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3076/) (Base Commit: de7602b) (PR Branch Commit: e9546e4)

tnozicka
tnozicka reviewed Jul 13, 2017
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mfojtik
Copy link
Contributor Author

mfojtik commented Jul 13, 2017

[merge]

@mfojtik
Copy link
Contributor Author

mfojtik commented Jul 13, 2017

[merge][severity:bug] this is a test flake fix, isolated in extended tests.

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to e9546e4

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1288/) (Base Commit: d32dd09) (PR Branch Commit: e9546e4) (Extended Tests: bug)

@openshift-merge-robot openshift-merge-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 24, 2017
@openshift-merge-robot openshift-merge-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2017
@0xmichalis
Copy link
Contributor

/test all

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2017
@tnozicka
Copy link
Contributor

tnozicka commented Jul 31, 2017 •
edited
Loading

(re-applying it for the new bot)
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@tnozicka tnozicka added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 31, 2017
@tnozicka
Copy link
Contributor

/test integration

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 15162, 14901, 15195)

@openshift-merge-robot openshift-merge-robot merged commit 0cb7fc4 into openshift:master Aug 1, 2017
@mfojtik mfojtik deleted the deploy-check-ist-sar branch September 5, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka left review comments

Assignees

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extended.deploymentconfigs when tagging images [Conformance] should successfully tag the deployed image
7 participants
@mfojtik @openshift-bot @0xmichalis @tnozicka @openshift-merge-robot @stevekuznetsov @openshift-ci-robot