Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix imports to the canonical packages #14617

Closed
wants to merge 2 commits into from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jun 13, 2017

Makes sure that all api package imports which would change in a refactor to match kube have aliases set to make the next step run smoothly.

@liggitt @smarterclayton Mostly done by script, fixup in a separate commit, plan to tag for merge on green (but not force merge since non-conflicting conflicts are likely).

[test][testextended][extended:core(builds)]

@@ -128,7 +128,7 @@ func TestLookup(t *testing.T) {
users: userRegistry,
}

identity := authapi.NewDefaultUserIdentityInfo(tc.ProviderName, tc.ProviderUserName)
identity := authuserapi.NewDefaultUserIdentityInfo(tc.ProviderName, tc.ProviderUserName)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, at least one failure. Hopefully I get a nice report

@deads2k deads2k added this to the 3.6.0 milestone Jun 15, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Jun 15, 2017

[severity:blocker]

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Jun 19, 2017

Mechanical change to set up for the API type moves.

@mfojtik ptal

@deads2k
Copy link
Contributor Author

deads2k commented Jun 19, 2017

No functional changes, fixes up imports for a later move.

[merge]

@mfojtik
Copy link
Contributor

mfojtik commented Jun 19, 2017

LGTM

@deads2k
Copy link
Contributor Author

deads2k commented Jun 19, 2017

the extended tests built.

@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Jun 19, 2017

flaked #14385

@openshift-bot
Copy link
Contributor

Evaluated for origin testextended up to 15616f6

@deads2k
Copy link
Contributor Author

deads2k commented Jun 19, 2017

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/656/) (Base Commit: 442a747) (PR Branch Commit: 15616f6) (Extended Tests: core(builds))

@smarterclayton
Copy link
Contributor

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 15616f6

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2415/) (Base Commit: b0c0635) (PR Branch Commit: 15616f6)

@deads2k
Copy link
Contributor Author

deads2k commented Jun 20, 2017

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 15616f6

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1056/) (Base Commit: e50d999) (PR Branch Commit: 15616f6) (Extended Tests: blocker)

@openshift-bot
Copy link
Contributor

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 20, 2017
@deads2k deads2k closed this Jun 23, 2017
@deads2k deads2k deleted the api-06-import branch August 3, 2017 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants