-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix imports to the canonical packages #14617
Conversation
@@ -128,7 +128,7 @@ func TestLookup(t *testing.T) { | |||
users: userRegistry, | |||
} | |||
|
|||
identity := authapi.NewDefaultUserIdentityInfo(tc.ProviderName, tc.ProviderUserName) | |||
identity := authuserapi.NewDefaultUserIdentityInfo(tc.ProviderName, tc.ProviderUserName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, at least one failure. Hopefully I get a nice report
[severity:blocker] |
Mechanical change to set up for the API type moves. @mfojtik ptal |
No functional changes, fixes up imports for a later move. [merge] |
LGTM |
the extended tests built. |
flaked #14385 |
Evaluated for origin testextended up to 15616f6 |
@smarterclayton hold on the flake? The rest passed https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1043/ and I have test run with a passing minimal here: https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2387/ |
continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/656/) (Base Commit: 442a747) (PR Branch Commit: 15616f6) (Extended Tests: core(builds)) |
[test] |
Evaluated for origin test up to 15616f6 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2415/) (Base Commit: b0c0635) (PR Branch Commit: 15616f6) |
[merge] |
Evaluated for origin merge up to 15616f6 |
continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1056/) (Base Commit: e50d999) (PR Branch Commit: 15616f6) (Extended Tests: blocker) |
Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again |
Makes sure that all api package imports which would change in a refactor to match kube have aliases set to make the next step run smoothly.
@liggitt @smarterclayton Mostly done by script, fixup in a separate commit, plan to tag for merge on green (but not force merge since non-conflicting conflicts are likely).
[test][testextended][extended:core(builds)]