switch to upstream controller roles and init functions where easily possible #14126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
soltysh
approved these changes
May 11, 2017
| } | ||
| controllerInitializers := kctrlmgr.NewControllerInitializers() | ||
|
|
||
| // TODO I think this should become a blacklist kept in sync during rebases with a unit test. |
There was a problem hiding this comment.
I can work on a followup up for that, if you want me to.
|
[merge] This is on the path to allowing bug fix #13996 |
|
ansible re[merge] |
|
Flake #14161 |
|
[merge] |
|
[test] |
|
re[test] re[merge] |
|
Not seeing how I affected vendor/k8s.io/kubernetes/pkg/controller/node.TestCancel |
|
Evaluated for origin test up to d0e3554 |
|
Evaluated for origin merge up to d0e3554 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/676/) (Base Commit: 3d82103) (Image: devenv-rhel7_6235) |
|
flake: #13966 [merge] |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1518/) (Base Commit: d33e176) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mfojtik I've tried to the keep the changes small-ish and easy to follow. There are no behavior or flow changes. This simply removes unnecessary roles and switches to upstream initialization where its zero change.
There are more changes to make that involve changes to the flow of controller init function creation. I'll save those for later.
Now that I have fewer
infra_sa_policy.goroles to deal with, I'm going to convert them to the upstream construction style.