-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dump events from e2e tests #14069
Dump events from e2e tests #14069
Conversation
[test] |
# None | ||
function os::cleanup::dump_events() { | ||
os::log::info "Dumping cluster events to ${ARTIFACT_DIR}/events.txt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make this debug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's worth moving at "debug". More often than not when debugging e2e I would prefer to see by default that a file with all the events has been placed somewhere. It's the same level as the dump we get from etcd, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. We still get debug
level in the scripts.log
artifact but OK.
hack/lib/cleanup.sh
Outdated
function os::cleanup::dump_events() { | ||
os::log::info "Dumping cluster events to ${ARTIFACT_DIR}/events.txt" | ||
oc get events --all-namespaces > "${ARTIFACT_DIR}/events.txt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this require admin? could use --config="${ADMIN_KUBECONFIG}"
if that's set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: Michail Kargakis <[email protected]>
Flake is #13966 |
Evaluated for origin test up to 61dc793 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1227/) (Base Commit: 17ebd78) |
[merge] |
Evaluated for origin merge up to 61dc793 |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/591/) (Base Commit: 9063c2c) (Image: devenv-rhel7_6217) |
Signed-off-by: Michail Kargakis [email protected]