Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump events from e2e tests #14069

Merged
merged 1 commit into from
May 9, 2017
Merged

Dump events from e2e tests #14069

merged 1 commit into from
May 9, 2017

Conversation

0xmichalis
Copy link
Contributor

Signed-off-by: Michail Kargakis [email protected]

@0xmichalis
Copy link
Contributor Author

[test]

# None
function os::cleanup::dump_events() {
os::log::info "Dumping cluster events to ${ARTIFACT_DIR}/events.txt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this debug

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's worth moving at "debug". More often than not when debugging e2e I would prefer to see by default that a file with all the events has been placed somewhere. It's the same level as the dump we get from etcd, too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. We still get debug level in the scripts.log artifact but OK.

function os::cleanup::dump_events() {
os::log::info "Dumping cluster events to ${ARTIFACT_DIR}/events.txt"
oc get events --all-namespaces > "${ARTIFACT_DIR}/events.txt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this require admin? could use --config="${ADMIN_KUBECONFIG}" if that's set

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Michail Kargakis <[email protected]>
@0xmichalis
Copy link
Contributor Author

0xmichalis commented May 5, 2017

Flake is #13966

@0xmichalis
Copy link
Contributor Author

0xmichalis commented May 8, 2017

#10738 #14096 #14097 [test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 61dc793

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1227/) (Base Commit: 17ebd78)

@0xmichalis
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 61dc793

@openshift-bot
Copy link
Contributor

openshift-bot commented May 9, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/591/) (Base Commit: 9063c2c) (Image: devenv-rhel7_6217)

@openshift-bot openshift-bot merged commit 31caa0d into openshift:master May 9, 2017
@0xmichalis 0xmichalis deleted the dump-events-from-e2e-tests branch May 10, 2017 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants