-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable minimization of net e2e runtime #11569
Conversation
[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Flake #11381 [test] |
flake #11381 re-[test] |
I think this is ready to merge - the networking job passed which is the only thing this PR affects. |
[test] |
Evaluated for origin test up to 8dddce6 |
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11251/) (Base Commit: d200e8a) |
|
Seems like the 1.3 branch is even worse for flakes than master. I'm going to propose we go ahead and merge. The networking job passed once already, and that's the only thing that this PR affects. Or is there a good reason to continue wasting everyone's collective time? |
@marun isn't that version error a real problem? |
@knobunc Sure, but it doesn't have anything to do with this change. If the networking job can run, this pr is doing its job. |
I'm assuming the problem in question is related to #10750 |
@marun I'm ok with merging this. @smarterclayton how do you feel? |
Basically, moving to Docker 1.12 broke unit tests for the release-1.3 branch. We haven't built out the support for multiple VMs today (one per release) for 3.x which is something we're trying to fix elsewhere. I'll probably just merge this, but we ultimately can't have release branches unless we can prevent the base VM from breaking old releases. |
@smarterclayton do you still want to see this merge? |
bump. why is this still here? |
This must not be important, but I'll leave the branch in case anyone wants to reopen. |
Backporting to release-1.3 as per #11504 (comment)
cc: @knobunc @smarterclayton