Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable minimization of net e2e runtime #11569

Closed
wants to merge 2 commits into from

Conversation

marun
Copy link
Contributor

@marun marun commented Oct 25, 2016

Backporting to release-1.3 as per #11504 (comment)

cc: @knobunc @smarterclayton

@marun
Copy link
Contributor Author

marun commented Oct 25, 2016

[test]

Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knobunc
Copy link
Contributor

knobunc commented Oct 25, 2016

Flake #11381 [test]

@marun
Copy link
Contributor Author

marun commented Nov 4, 2016

flake #11381 re-[test]

@marun
Copy link
Contributor Author

marun commented Nov 4, 2016

I think this is ready to merge - the networking job passed which is the only thing this PR affects.

@smarterclayton
Copy link
Contributor

[test]

@marun
Copy link
Contributor Author

marun commented Nov 8, 2016

flakes #11381 #11452 re-[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 8dddce6

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11251/) (Base Commit: d200e8a)

@knobunc
Copy link
Contributor

knobunc commented Nov 8, 2016

--- FAIL: TestRouterServiceUnavailable (0.52s)
    router_test.go:973: Error starting container openshift/origin-haproxy-router : API error (400): {"message":"starting container with HostConfig was deprecated since v1.10 and removed in v1.12"}

@marun
Copy link
Contributor Author

marun commented Nov 9, 2016

Seems like the 1.3 branch is even worse for flakes than master. I'm going to propose we go ahead and merge. The networking job passed once already, and that's the only thing that this PR affects. Or is there a good reason to continue wasting everyone's collective time?

@knobunc
Copy link
Contributor

knobunc commented Nov 10, 2016

@marun isn't that version error a real problem?

@marun
Copy link
Contributor Author

marun commented Nov 14, 2016

@knobunc Sure, but it doesn't have anything to do with this change. If the networking job can run, this pr is doing its job.

@marun
Copy link
Contributor Author

marun commented Nov 14, 2016

I'm assuming the problem in question is related to #10750

@knobunc
Copy link
Contributor

knobunc commented Nov 15, 2016

@marun I'm ok with merging this. @smarterclayton how do you feel?

@smarterclayton
Copy link
Contributor

smarterclayton commented Nov 15, 2016

Basically, moving to Docker 1.12 broke unit tests for the release-1.3 branch. We haven't built out the support for multiple VMs today (one per release) for 3.x which is something we're trying to fix elsewhere. I'll probably just merge this, but we ultimately can't have release branches unless we can prevent the base VM from breaking old releases.

@marun
Copy link
Contributor Author

marun commented Jan 3, 2017

@smarterclayton do you still want to see this merge?

@marun
Copy link
Contributor Author

marun commented Feb 18, 2017

bump. why is this still here?

@marun
Copy link
Contributor Author

marun commented Apr 18, 2017

This must not be important, but I'll leave the branch in case anyone wants to reopen.

@marun marun closed this Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants