Tests: don't clone openshift/origin where possible

[mmilata]

Fixes #7430.

[mmilata]

Modified jenkins/kubernetes_plugin.go to not clone origin. There's some template preprocessing that's needed in order to use binary builds - could be avoided by making a copy of the template but I didn't like the idea of maintaining two almost identical files in the repo.

The test passes now (takes ~7 min on my VM), should I remove it from the list of excluded tests?

[bparees]

@mmilata how is it being excluded currently? (which bucket is it being excluded from)?

[mmilata]

@bparees it's listed in EXCLUDED_TESTS here: https://github.com/openshift/origin/blob/master/test/extended/setup.sh#L262

[bparees]

yeah you can remove it from there. it doesn't matter all that much because it's already excluded by being marked Slow and it is indeed slow. Also the excluded tests are still run when you explicitly request a ginkgo filter, so when we do our extended test job it does get run. but for cleanliness, sure remove that line.

[bparees]

also that text doesn't actually match any current test description....

[bparees]

ah i guess it matches by concatenation, nm

[mmilata]

Removed from the excluded list.

[bparees]

[testextended][extended:core(builds)]

[bparees]

[testextended][extended:core(jenkins)]

[bparees]

lgtm, will merge if/when extended tests pass.

@gabemontero this jenkins test is one of the ones you're moving into image_ecosystem in another PR, right?

[mmilata]

The test failure looks like something that might've been fixed by #11508. Let's try again.
[testextended][extended:core(jenkins)]

[openshift-bot]

Evaluated for origin testextended up to 53b0a7e

[openshift-bot]

continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/666/) (Base Commit: 84cddbc) (Extended Tests: core(jenkins), core(builds))

[bparees]

[merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10548/) (Image: devenv-rhel7_5236)

[openshift-bot]

Evaluated for origin merge up to 53b0a7e

[openshift-bot]

[Test]ing while waiting on the merge queue

[openshift-bot]

Evaluated for origin test up to 53b0a7e

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10548/) (Base Commit: 9195050)

[gabemontero]

On Fri, Oct 21, 2016 at 11:20 AM, Ben Parees [email protected]
wrote:

lgtm, will merge if/when extended tests pass.

@gabemontero https://github.com/gabemontero this jenkins test is one of
the ones you're moving into image_ecosystem in another PR, right?

yep i'll rebase when this merges ... and @mmilata looks to have
incorporated the fixes to kubernetes_plugin.go
as well

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11392 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADbadGBhayBhnI3_ZK-I9B1sGCVkiGGrks5q2NgigaJpZM4KYnWB
.

[bparees]

@gabemontero this already merged, but between your comment and a few from @smarterclayton i'm thinking github is just finally delivering old email responses you guys sent.

[gabemontero]

Yeah I made that last comment a few days ago. We are good here (as of Tue Oct 25 2:50 Eastern).