Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pod bash completion oc exec #11329

Conversation

juanvallejo
Copy link
Contributor

@juanvallejo juanvallejo commented Oct 11, 2016

Fixes #10273

Adds bash and zsh tab completion to oc exec

cc @stevekuznetsov @openshift/cli-review

@stevekuznetsov
Copy link
Contributor

Isn't this going to mess with the auto-gen? Does hack/verify-generated-completions.sh pass?

@juanvallejo juanvallejo force-pushed the jvallejo/add-bash-completion-oc-exec branch from 3bade03 to f43b600 Compare October 11, 2016 20:51
@juanvallejo
Copy link
Contributor Author

@stevekuznetsov passing now, had forgotten to update completions

@juanvallejo
Copy link
Contributor Author

[test]

@juanvallejo
Copy link
Contributor Author

#11315 re[test]

@fabianofranz
Copy link
Member

@juanvallejo squash into one.

@juanvallejo juanvallejo force-pushed the jvallejo/add-bash-completion-oc-exec branch from f43b600 to 63856c2 Compare October 13, 2016 20:40
@juanvallejo
Copy link
Contributor Author

@fabianofranz Done!

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 63856c2

@fabianofranz
Copy link
Member

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 13, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10028/) (Image: devenv-rhel7_5179)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 63856c2

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10028/) (Base Commit: 66a729c)

@openshift-bot openshift-bot merged commit f096e61 into openshift:master Oct 14, 2016
@juanvallejo juanvallejo deleted the jvallejo/add-bash-completion-oc-exec branch October 14, 2016 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants