Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates oc run examples #11188

Merged
merged 1 commit into from
Oct 6, 2016
Merged

Updates oc run examples #11188

merged 1 commit into from
Oct 6, 2016

Conversation

jtslear
Copy link
Contributor

@jtslear jtslear commented Oct 3, 2016

@jtslear
Copy link
Contributor Author

jtslear commented Oct 4, 2016

I appear to be unable to regenerate the docs per the CI failure:

[vagrant@localhost origin]$ ./hack/update-generated-docs.sh
++ Building go targets for linux/amd64: tools/gendocs tools/genman
# github.com/openshift/origin/pkg/cmd/cli/cmd/login
pkg/cmd/cli/cmd/login/loginoptions.go:136: undefined: tls.RecordHeaderError
# github.com/openshift/origin/pkg/cmd/cli/cmd/observe
pkg/cmd/cli/cmd/observe/observe.go:360: exit.Stderr undefined (type *"os/exec".ExitError has no field or method Stderr)
pkg/cmd/cli/cmd/observe/observe.go:361: exit.Stderr undefined (type *"os/exec".ExitError has no field or method Stderr)
[ERROR] PID 10664: hack/common.sh:244: `( os::build::internal::build_binaries "${binaries[@]+"${binaries[@]}"}" )` exited with status 1.
[INFO]          Stack Trace:
[INFO]            1: hack/common.sh:244: `( os::build::internal::build_binaries "${binaries[@]+"${binaries[@]}"}" )`
[INFO]            2: hack/build-go.sh:24: os::build::build_binaries
[INFO]   Exiting with code 1.
[ERROR] PID 10653: hack/update-generated-docs.sh:7: `"${OS_ROOT}/hack/build-go.sh" tools/gendocs tools/genman` exited with status 1.
[INFO]          Stack Trace:
[INFO]            1: hack/update-generated-docs.sh:7: `"${OS_ROOT}/hack/build-go.sh" tools/gendocs tools/genman`
[INFO]   Exiting with code 1.

@fabianofranz any ideas on the above?

@fabianofranz
Copy link
Member

@jtslear never saw that, which go version are you using?

@jtslear
Copy link
Contributor Author

jtslear commented Oct 4, 2016

@fabianofranz I'm using the vagrant dev environment in this case.

[vagrant@localhost origin]$ go version
go version go1.5.4 linux/amd64

@fabianofranz
Copy link
Member

@jtescher that might be the reason, we target at Go 1.6+ for building oc and running ./hack/update-generated-docs.sh. Make sure you are up-to-date.

@jtescher
Copy link
Contributor

jtescher commented Oct 4, 2016

@fabianofranz s/jtescher/jtslear/

@fabianofranz
Copy link
Member

s/jtescher/jtslear/

oops sorry, @jtslear ^

@jtslear
Copy link
Contributor Author

jtslear commented Oct 4, 2016

Assuming this builds properly, should I squash these two commits?

@jtslear
Copy link
Contributor Author

jtslear commented Oct 4, 2016

💥 @fabianofranz , it's now ready for review :-)

@fabianofranz
Copy link
Member

@jtslear yes, please squash into one commit. Thanks for the PR!

* Removes a todo item from the list
* Test coverage provided by kubernetes/kubernetes#13917
* closes openshift#8620
@jtslear
Copy link
Contributor Author

jtslear commented Oct 4, 2016

@fabianofranz tis done.

@fabianofranz
Copy link
Member

LGTM [merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to d3851ba

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9636/)

@fabianofranz
Copy link
Member

Flaked on #11094
re[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to d3851ba

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 6, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9691/) (Image: devenv-rhel7_5138)

@openshift-bot openshift-bot merged commit 949be1e into openshift:master Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncomment some 'oc run' examples
5 participants