-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates oc run
examples
#11188
Updates oc run
examples
#11188
Conversation
I appear to be unable to regenerate the docs per the CI failure:
@fabianofranz any ideas on the above? |
@jtslear never saw that, which |
@fabianofranz I'm using the vagrant dev environment in this case.
|
@jtescher that might be the reason, we target at Go 1.6+ for building |
@fabianofranz s/jtescher/jtslear/ |
oops sorry, @jtslear ^ |
Assuming this builds properly, should I squash these two commits? |
💥 @fabianofranz , it's now ready for review :-) |
@jtslear yes, please squash into one commit. Thanks for the PR! |
* Removes a todo item from the list * Test coverage provided by kubernetes/kubernetes#13917 * closes openshift#8620
@fabianofranz tis done. |
LGTM [merge] |
[Test]ing while waiting on the merge queue |
Evaluated for origin test up to d3851ba |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9636/) |
Flaked on #11094 |
Evaluated for origin merge up to d3851ba |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9691/) (Image: devenv-rhel7_5138) |
--
kubernetes/kubernetes#13917