e2e: schema 2 config test amendments #10812
Conversation
miminar
force-pushed
the
schema2-manifest-config-test-amendments
branch
from
a46ac0f to
71f6088
Compare
|
[test] |
|
[testextended][extended:core(images)][extended:core(builds)] |
|
@stevekuznetsov PTAL |
miminar
force-pushed
the
schema2-manifest-config-test-amendments
branch
from
71f6088 to
4f82de9
Compare
| os::cmd::expect_failure_and_text "docker push ${DOCKER_REGISTRY}/custom/cross:namespace-pull" "authentication required|not authorized" | ||
| os::cmd::expect_failure_and_text "docker push ${DOCKER_REGISTRY}/custom/cross:namespace-pull-id" "authentication required|not authorized" | ||
| # unauthorized pushes return authorization errors, regardless of backing data; error messages differ with each docker version | ||
| # docker 1.9: not authorized |
There was a problem hiding this comment.
Still not convinced we want this
There was a problem hiding this comment.
It's true that e2e test won't complete with docker 1.9. I've reverted it back.
|
Changes mostly LGTM, still not sure we want this in e2e core |
|
@liggitt duly noted, thanks |
miminar
force-pushed
the
schema2-manifest-config-test-amendments
branch
from
4f82de9 to
fe0fdd9
Compare
|
Comments addressed. |
- Quote process expansions.
- Use braces for variable expansions (e.g. ${var}).
- Wrap variable expandions with quotes.
Signed-off-by: Michal Minář <[email protected]>
miminar
force-pushed
the
schema2-manifest-config-test-amendments
branch
from
fe0fdd9 to
d173539
Compare
|
Evaluated for origin test up to d173539 |
|
Evaluated for origin testextended up to d173539 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8739/) |
|
continuous-integration/openshift-jenkins/testextended FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/464/) (Extended Tests: core(images)) |
|
LGTM |
|
@mfojtik merge? |
|
@miminar still code freeze. |
|
@mfojtik good to merge now? |
|
[merge] |
|
Evaluated for origin merge up to d173539 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8739/) (Image: devenv-rhel7_5129) |
A follow-up for #10805